Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product Editor: Fix modal block editor crashing when Add button clicked with Gutenberg 18.3.0 #47561

Merged
merged 9 commits into from
May 20, 2024
Merged

Product Editor: Fix modal block editor crashing when Add button clicked with Gutenberg 18.3.0 #47561

merged 9 commits into from
May 20, 2024

Conversation

mattsherman
Copy link
Contributor

@mattsherman mattsherman commented May 16, 2024 •
edited

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR fixes the modal block editor crashing when clicking the + (Add) button in the modal block editor header to bring up the block inserter sidebar when Gutenberg 18.3.0 is installed.

Please note that the block inserter sidebar looks different with different Gutenberg versions...

No Gutenberg, or Gutenberg 18.2.0 or below

Screenshot 2024-05-17 at 11 32 26

Gutenberg 18.3.0

Screenshot 2024-05-17 at 11 36 13

Gutenberg 18.4.0.rc-1 or later

Screenshot 2024-05-17 at 12 12 37

Closes #47560.

How to test the changes in this Pull Request:

Go through the following test instructions for each of the following environments:

  • Gutenberg plugin not installed
  • Gutenberg 18.2.0 plugin installed (zip)
  • Gutenberg 18.3.0 plugin installed (get from plugin directory)
  • Gutenberg 18.4.0-rc.1 (zip)
  • Gutenberg with fix branch (zip) (might need to clear your browser cache when switching to this, as it has the same version number as 18.4.0-rc.1)

With a WooCommerce env with the new product editor enabled (WooCommerce > Settings > Advanced > Features > Experimental features)...

  1. Go to Products > Add New
  2. Click on Description > Full Editor to bring up the modal editor
  3. Click the + button in the modal header to bring up the block inserter sidebar
  4. Add a block and verify it gets added to the editor
  5. Click the X button in the modal header to close the block inserter sidebar
  6. If using Gutenberg with fix branch...
    • Open up the block inserter sidebar again by clicking the + button in the modal header
    • Click the x button in the sidebar header (next to the Blocks, Patterns, Media tabs) and verify the block inserter sidebar closes

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@mattsherman mattsherman self-assigned this May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@mattsherman mattsherman changed the title Fix/product editor modal block editor add crash Product Editor: Fix modal block editor crashing when Add button clicked with Gutenberg 18.3.0 May 17, 2024
@mattsherman mattsherman mentioned this pull request May 17, 2024
Merged
@mattsherman mattsherman added focus: new product ux revamped product management experience type: bug The issue is a confirmed bug. team: Mothra labels May 17, 2024
@mattsherman mattsherman marked this pull request as ready for review May 17, 2024 16:34
@mattsherman mattsherman requested a review from a team May 17, 2024 16:36
@github-actions GitHub Actions
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

retrofox
retrofox approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested and it fixes the bug that breaks the app.
Nice one!
:shipit:

@mattsherman mattsherman merged commit a6b0bb7 into trunk May 20, 2024
40 checks passed
@mattsherman mattsherman deleted the fix/product-editor-modal-block-editor-add-crash branch May 20, 2024 12:36
@github-actions github-actions bot added this to the 9.0.0 milestone May 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 20, 2024
@alvarothomas alvarothomas modified the milestones: 9.0.0, 8.9.0 May 20, 2024
github-actions bot pushed a commit that referenced this pull request May 20, 2024
@mattsherman
Product Editor: Fix modal block editor crashing when Add button click…
aa1a4b7 
…ed with Gutenberg 18.3.0 (#47561)
@github-actions github-actions bot mentioned this pull request May 20, 2024
Merged
alvarothomas pushed a commit that referenced this pull request May 20, 2024
@github-actions @mattsherman
Cherry pick 47561 into release/8.9 (#47617)
ea6380c 
Product Editor: Fix modal block editor crashing when Add button clicked with Gutenberg 18.3.0 (#47561)

Co-authored-by: Matt Sherman <matt.sherman@automattic.com>
alvarothomas added a commit that referenced this pull request May 20, 2024
@alvarothomas
Update readme.txt
1791d81 
Update changelog after cherry-picking #47561 and update release date to 2024-05-21.
@rodelgc rodelgc added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrofox retrofox retrofox approved these changes

Assignees

@mattsherman mattsherman

Labels
fix release: 8.9.1 focus: new product ux revamped product management experience needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
8.9.0
5 participants
@mattsherman @retrofox @rodelgc @alvarothomas @nigeljamesstevenson