-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Editor: Fix modal block editor crashing when Add button clicked with Gutenberg 18.3.0 #47561
Product Editor: Fix modal block editor crashing when Add button clicked with Gutenberg 18.3.0 #47561
Conversation
…atches core implementation)
…e implementation)
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tested and it fixes the bug that breaks the app.
Nice one!
…ed with Gutenberg 18.3.0 (#47561)
Product Editor: Fix modal block editor crashing when Add button clicked with Gutenberg 18.3.0 (#47561) Co-authored-by: Matt Sherman <matt.sherman@automattic.com>
Update changelog after cherry-picking #47561 and update release date to 2024-05-21.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes the modal block editor crashing when clicking the + (Add) button in the modal block editor header to bring up the block inserter sidebar when Gutenberg 18.3.0 is installed.
Please note that the block inserter sidebar looks different with different Gutenberg versions...
No Gutenberg, or Gutenberg 18.2.0 or below
Gutenberg 18.3.0
Gutenberg 18.4.0.rc-1 or later
Closes #47560.
How to test the changes in this Pull Request:
Go through the following test instructions for each of the following environments:
With a WooCommerce env with the new product editor enabled (WooCommerce > Settings > Advanced > Features > Experimental features)...
Changelog entry
Significance
Type
Message
Comment