-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make shipping total in Cart/Checkout block order summaries show FREE if shipping price is 0 #47553
Conversation
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Hi @senadir, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
@opr you need to update tests that still refer to |
Thanks, yeah I plan to work on this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks out!
Changes proposed in this Pull Request:
This PR will show the text 'FREE' in bold and capital letters in the order summary on the Cart and Checkout block.
It also adds a unit test to cover this, and fixes a TS issue with some earlier tests.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Enable the shipping calculator on the cart page
is checked.Changelog entry
Significance
Type
Message
Comment