Fix two flaky e2e tests

[lanej0]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Fixes two flaky tests: basic.spec.js (which was identified by Buildkite as being flaky) and Closes: #46666

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Ensure CI passes
2. pnpm env:restart && pnpm test:e2e-pw basic.spec.js --repeat-each 5
3. pnpm test:e2e-pw checkout-block.spec.js --repeat-each 5

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Hi @adimoldovan,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[lanej0]

Meant to add a comment on this:

I know this is a goofy thing, and a .fill() shouldn't need a .click() preceding it. It looks like in about 10% of executions, Playwright starts to fill in the login form before the page has finished loading and that there is a focus() on the username field that fires right before we start filling out the password -- so the password ends up overwriting the username (and that causes the flakiness/failure). Explicitly clicking on each field before filling it out seems to have fixed that.

[adimoldovan]

Thanks @lanej0 for working on this. It looks much better.