Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing workflows] Move PHP tests with WP nighly back into ci.yml #47568

Merged
merged 3 commits into from
May 21, 2024

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented May 17, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

With optional tests now supported in ci.yml we can move the WP nightly back. They were removed by #45096 and then added to a cron workflow with #45260.

How to test the changes in this Pull Request:

Check CI, make sure PHP WP: nightly are running for @woocommerce/plugin-woocommerce. The job should be optional.

@adimoldovan adimoldovan self-assigned this May 17, 2024
@github-actions github-actions bot added focus: monorepo infrastructure Issues and PRs related to monorepo tooling. plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@adimoldovan adimoldovan marked this pull request as ready for review May 17, 2024 16:45
@woocommercebot woocommercebot requested a review from a team May 17, 2024 16:46
Copy link
Contributor

Hi , @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@rrennick rrennick merged commit 3edf17b into trunk May 21, 2024
28 checks passed
@rrennick rrennick deleted the ci/add-php-nightly-back-to-ci branch May 21, 2024 21:23
@github-actions github-actions bot added this to the 9.0.0 milestone May 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 21, 2024
@Stojdza Stojdza added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants