Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Collection: remove Beta label #47572

Merged
merged 4 commits into from
May 21, 2024

Conversation

kmanijak
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR removes the Beta label from Product Collection and we make it stable.

Closes #43397

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to Editor and try adding Product Collection block
  2. Make sure there's Product Collection and not Product Collection (Beta)
  3. Add block, choose Product Catalog
  4. Make sure the block's called Product Collection in Inspector Controls
image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@kmanijak kmanijak added team: Kirigami & Origami type: new block Applied to work that introduces a new block (typically used on an epic issue). block: product collection Issues related to the Product Collection block labels May 17, 2024
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@kmanijak kmanijak marked this pull request as ready for review May 17, 2024 10:19
@kmanijak kmanijak requested a review from imanish003 May 17, 2024 10:19
@woocommercebot woocommercebot requested a review from a team May 17, 2024 10:19
@kmanijak kmanijak requested review from manospsyx and ObliviousHarmony and removed request for a team May 17, 2024 10:19
Copy link
Contributor

github-actions bot commented May 17, 2024

Hi @manospsyx, @ObliviousHarmony, @imanish003,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@imanish003 imanish003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did smoke testing with Product Collection block and it is working as expected after removing the Beta label. I left one minor comment. Everything else looks good to me :shipit: 🎉

@@ -578,7 +578,7 @@ Payment options for your store.

## Pickup Method - woocommerce/checkout-pickup-options-block

Shows local pickup options.
Shows local pickup locations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more such changes in this file. I don't think these are directly related to removing the Beta label. Are these changes intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are based on an automatic script build:docs:block-references. So it gets the newest data from blocks (title, descriptions, attributes etc.).

In order to update Product Collection name in Blocks Reference file, we also get all the other updates for free.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Understood. I will perform smoke testing again and then approve the PR. Thanks for the explanation 🙌🏻

Copy link
Contributor

@imanish003 imanish003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM! Excited to see the "Beta" label removed from Product Collection block. This marks a significant milestone, reflecting the hard work and dedication put into stabilizing this. Let's roll this out! 🎉

@kmanijak kmanijak merged commit 929564d into trunk May 21, 2024
38 checks passed
@kmanijak kmanijak deleted the 43397-product-collection-remove-beta-label branch May 21, 2024 06:36
@github-actions github-actions bot added this to the 9.0.0 milestone May 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 21, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: product collection Issues related to the Product Collection block focus: e2e tests Issues related to e2e tests needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: new block Applied to work that introduces a new block (typically used on an epic issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Collection: Remove Beta label
3 participants