-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Collection: remove Beta label #47572
Conversation
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Hi @manospsyx, @ObliviousHarmony, @imanish003, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did smoke testing with Product Collection block and it is working as expected after removing the Beta label. I left one minor comment. Everything else looks good to me 🎉
@@ -578,7 +578,7 @@ Payment options for your store. | |||
|
|||
## Pickup Method - woocommerce/checkout-pickup-options-block | |||
|
|||
Shows local pickup options. | |||
Shows local pickup locations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more such changes in this file. I don't think these are directly related to removing the Beta label. Are these changes intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are based on an automatic script build:docs:block-references
. So it gets the newest data from blocks (title, descriptions, attributes etc.).
In order to update Product Collection name in Blocks Reference file, we also get all the other updates for free.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! Understood. I will perform smoke testing again and then approve the PR. Thanks for the explanation 🙌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM! Excited to see the "Beta" label removed from Product Collection block. This marks a significant milestone, reflecting the hard work and dedication put into stabilizing this. Let's roll this out! 🎉
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR removes the Beta label from Product Collection and we make it stable.
Closes #43397
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Product Collection
and notProduct Collection (Beta)
Changelog entry
Significance
Type
Message
Comment