Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrepreneur Signup: Hide progress bar when entering Design With AI from Entrepreneur signup flow. #47574

Merged
merged 2 commits into from
May 20, 2024

Conversation

yansern
Copy link
Contributor

@yansern yansern commented May 17, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Hide progress bar when entering Design With AI from Entrepreneur signup flow.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Sync to your WoA site on Entrepreneur plan.
  2. Go to Design With AI your_site_here.wpcomstaging.com/wp-admin/admin.php?page=wc-admin&path=%2Fcustomize-store%2Fdesign-with-ai&ref=entrepreneur-signup.
  3. The red progress bar on top should not show.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • [s] Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@yansern yansern marked this pull request as draft May 17, 2024 11:24
Copy link
Contributor

github-actions bot commented May 17, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@yansern yansern self-assigned this May 17, 2024
@yansern yansern marked this pull request as ready for review May 17, 2024 13:57
@yansern yansern added focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 17, 2024
@mashikag
Copy link

I tested on an Entrepreneur plan WoA site, and it works as expected when the ref=entrepreneur-signup is appended to the URL. 👌

Before After

When ref=entrepreneur-signup is not appended to the URL, the progress bar is still displayed.

Copy link

@mashikag mashikag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I do not have the powers to approve the PR. 🙂

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM! Thanks! 🚢

@gigitux gigitux merged commit ce42e92 into trunk May 20, 2024
32 checks passed
@gigitux gigitux deleted the update/entrepreneur-signup-hide-progress-bar branch May 20, 2024 11:04
@github-actions github-actions bot added this to the 9.0.0 milestone May 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 20, 2024
@rodelgc rodelgc added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. needs: internal testing Indicates if the PR requires further testing conducted by Solaris labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants