[Feature request] Retrieve column letter #2091 #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you. When will this be implemented? |
|
I am not quite sure about the motivation of this PR as the function is already implemented (I didn't remember this, so forgot to mention it in #2091). Also keep in mind that xlwings.utils is also been more of an internal API. The new implementation is almost twice as slow as the current implementation, so not likely an improvement? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #2091.
I noted that you had a function that achieves this task. My PR contains a reworked version of
xw.utils.col_nameinclusive of a few test using pytests to ensure that the function works as expected.