Quarkus extension updated to Elide 7 and Quarkus 3.7 #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd Quarkus 3.7
|
Thanks for updating this to Elide 7. I'm running the screwdriver build/tests now. |
Doom9527
pushed a commit
to paion-data/elide
that referenced
this pull request
Apr 3, 2024
…nd Quarkus 3.7 (yahoo#3160) Co-authored-by: Peter Royle <pete@spruce.ki>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simply copied and modified the code previously submitted by @aklish to make their experimental Elide Quarkus Extension compatible with Quarkus 3.7 and Elide 7.
Please note I'm not actually suggesting to merge this into master at this point. Would be happy for it to be merged into a new branch, or into the existing QuarkusScaffold branch if possible (more on that below)
Relates to #2279
Description
I initially tried merging master into the QuarkusScaffolding branch and going from there, in order to maintain the original commit authorship of the quarks-extension by @aklish , but there were nearly a thousand conflicts for reasons I don't understand. You are more than welcome to use this branch as the basis for merging the updated quarkus extension code over the top of the existing code written by @aklish if you can manage it.
Instead I ended up creating the Quarks37Scaffolding branch from master, copying only the Elide Quarkus Extension code (/elide-quarkus) from the QuarkusScaffolding branch and modifying it until it worked. It's possible some of the decisions I've made to get it working are questionable. Specifically, the last 4 producer methods in ElideBeans.java might be an area for improvement, as I wasn't exactly sure what was required to be produced, I just simply satisfied the dependency injection requirements.
Motivation and Context
This allows work to continue towards an Elide Quarkus extension. I simply like both frameworks and don't want to have to choose between them!
How Has This Been Tested?
The original test classes written by @aklish are intact and passing. I have also briefly tested using the extension with a sample project of my own running Quarkus 3.7.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.