Fluxible router improve dehydration #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides avoiding unnecessary data to be sent to the client (given that RouteStore currently doesn't need currentNavigate.route to re-hydrate), we prevent browsers to break given that currentNavigate.route.action and currentNavigate.route.handler may contain server transpiled code that is not compatible with them.
pablopalacios
changed the base branch from
master
to
fluxible-addons-react-1.x-dev
|
@redonkulus here is the fluxible-router cherry-pick |
pablopalacios
added a commit
to pablopalacios/fluxible
that referenced
this pull request
Jul 17, 2021
…ahoo#672) Besides avoiding unnecessary data to be sent to the client (given that RouteStore currently doesn't need currentNavigate.route to re-hydrate), we prevent browsers to break given that currentNavigate.route.action and currentNavigate.route.handler may contain server transpiled code that is not compatible with them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #670
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.