Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portico: Update message content on /for/X pages #30131

Closed
wants to merge 2 commits into from
Closed

portico: Update message content on /for/X pages #30131

wants to merge 2 commits into from

Conversation

roanster007
Copy link
Collaborator

Fixes: #30128

Screenshots and screen captures:

image


image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @zulip/server-misc members, this pull request was labeled with the "area: portico" label, so you may want to check it out!

@roanster007 roanster007 mentioned this pull request May 18, 2024
Open
2 tasks
@roanster007
Copy link
Collaborator Author

I'm not sure of the location for these screenshots.

@timabbott
Copy link
Sponsor Member

I'm not sure of the location for these screenshots.

There are existing screenshots on those pages that these update/modernize, so you should be just swapping the images in place.

@roanster007
portico: Add user avatars directory.
7224427 
This commit adds a user avatars directory, with avatars for some
users, which could be used while generating screenshots.
@roanster007
portico: Update screenshots for "for/business", "for/open-source" pages.
4fb5be4 
This commit updates screenshots for the "for/business" and
"for/open-source" pages, and adds the script for generating
their screenshots at "screenshots/message-formatting.json."

Partly fixes zulip#30128
@roanster007
Copy link
Collaborator Author

roanster007 commented May 21, 2024 •
edited

Updated screenshots setting - "for/business", "for/open-source".

@roanster007
Copy link
Collaborator Author

Closing this and adding it as a commit in #30159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: portico size: L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update message content on /for/X pages
3 participants
@roanster007 @zulipbot @timabbott