Explicit Taylor Sum Kernels #1044
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temp memory avoid Correct order Almost-bug fixes More fixes Correcting index again Include guards Forward define Correct library Trying to fix the build again
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1044 +/- ##
=======================================
Coverage 13.79% 13.79%
=======================================
Files 268 268
Lines 15011 15011
=======================================
Hits 2071 2071
Misses 12940 12940 ☔ View full report in Codecov by Sentry. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the some of Taylor sum kernels do very small reads and writes—which is bad. Therefore, we for now fuse them manually, until our code generation can help us here.
Note that the results will be slightly different—since we now use
realeverywhere during the computation.(yes, I know that "some" and "sum" sound similar, non-intended pun :P)
Draft until performance verified everywhere.