-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewriting Parts of the IO in SeisSol [Tracking PR] #1103
Draft
davschneller
wants to merge
73
commits into
master
Choose a base branch
from
davschneller/base-io
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davschneller
force-pushed
the
davschneller/base-io
branch
from
May 13, 2024 19:52
9c843f0
to
945bfc6
Compare
davschneller
force-pushed
the
davschneller/base-io
branch
from
May 13, 2024 20:40
216cb4c
to
b5f04f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IO has mainly suffered under one flaw: having an additional thread or additional IO rank requires the IO part to be programmed in a special way: it is not easily possible to convey a structure to write to the IO ranks. As a result, it became cumbersome to add new data to the output.
To solve this issue, we introduce a primitive serialization mechanism via the already-used YAML module. That is, we collect all write commands (i.e. specify the file, and for HDF5 also the datatype) and assign them buffer IDs. Currently, this new IO structure supports Hdf5 only. However, adding a direct binary file writing option should be easily doable. Apart from that, we tackle the checkpointing and high-order output issues with this PR (cf. WP2 and WP3 of our IO Konwihr proposal). That is, the old checkpointing backend is removed completely since it was already obsolete. The new checkpointing is currently still WIP, but already works on one rank for wavepropagation. For now, it'll focus on dumping and reading the necessary memory. We also add the VTK high-order output options—subdivision for the new output is not yet implemented. Same also for vertex filtering—if it should be needed at all with higher orders.
Draft PR due to the design of the module being a bit chaotic at the moment—that may need to be cleaned up first.
(but PR at all, since it's beginning to be usable already)
Some tracking points:
Currently, to enable the high-order IO, add
wavefieldvtkorder=N
(in theoutput
section), where N is the polynomial degree you want the output to have. Similarly,surfacevtkorder=N
(in theoutput
section) for high-order free-surface output, andvtkorder=N
in theelementwise
section for high-order fault output. Negative values will resort to the well-known Xdmf output. Note thatN=0
is still unsupported at the moment—but you can resort for Xdmf for that.Feel free to use/test.