Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up pre/postprocessing #872

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Conversation

davschneller
Copy link
Contributor

@davschneller davschneller commented May 31, 2023

This PR shall clean up the pre/postprocessing folders (if possible, move anything still needed into their own repositories), and remove some old scons files.

The following is done:

  • site_scons has been removed
  • The submodules scons-tools and cxxtest have been removed
  • Documentation/UserManual was cleaned up, except for RD_sign_conventions.*.
  • For preprocessing:
  • For postprocessing:

@sebwolf-de
Copy link
Contributor

We could leave rconv in the SeisSol repository for now, since it does not fit into neither meshing nor visualization.
I'd keep validation here or move it to precomputed-seissol. We need the scripts there for the tests.

@davschneller
Copy link
Contributor Author

davschneller commented Jun 3, 2023

Personally, I think it would be good to have all compilable code but SeisSol itself out of the repo—at least long-term. I.e. we can also stop here for this PR and finish it.

More thoughts:

  • In Port the preprocessing/meshing folder from the SeisSol repository to here Meshing#48 , Thomas suggested to turn the repositories into preprocessing (formerly Meshing and maybe Geodata) and postprocessing (formerly Visualization). ... Or should we maybe merge all of them into one? (we could also introduce a repository with submodules)
  • I agree that rconv doesn't really fit into any of the existing repositories. Maybe, it would do best in a repository on its own, since the SeisSol/Examples repository uses it for e.g. WP2_LOH1. So why not make it like pumgen?
  • That would leave only cube_c without its own repo (which is needed for the convergence tests).
  • Also, it seems like gmsh2gambit is sort of obsolete at this point? The SeisSol/Examples repository goes directly from gmsh to pumgen. TODO: remove it from the cookbook then, I'd guess.

Or we can really leave the validation and science folders in here for now (since the latter have PRs for them). Maybe move rconv out, or not. Moving the validation to precomputed-seissol also seems good, although the scripts are not tied to the data there—so it's only maybe the right place for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants