-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean Up pre/postprocessing #872
base: master
Are you sure you want to change the base?
Conversation
We could leave |
Personally, I think it would be good to have all compilable code but SeisSol itself out of the repo—at least long-term. I.e. we can also stop here for this PR and finish it. More thoughts:
Or we can really leave the validation and science folders in here for now (since the latter have PRs for them). Maybe move |
This PR shall clean up the pre/postprocessing folders (if possible, move anything still needed into their own repositories), and remove some old scons files.
The following is done:
site_scons
has been removedscons-tools
andcxxtest
have been removedDocumentation/UserManual
was cleaned up, except forRD_sign_conventions.*
.preprocessing
:meshing
: moved. See Port thepreprocessing/meshing
folder from the SeisSol repository to here Meshing#48 .partitioning
: removed (due to age). Onlygambit.py
was used bymeshing/cube
, so it has been copied to SeisSol/Meshing.science
: unsure what to do... (keep? Although extracting rconv would be good, I'd say. But where to put it?)workflow
: removed (due to age)postprocessing
:performance
: removed (due to age)science
: unsure what to do... (or where to put)validation
: unsure what to do... (or where to put)visualization
: moved. See Port from SeisSol/postprocessing/visualization Visualization#10 .Since there are some points for which I'm not sure what to do, this PR is still a draft.