Mw from slipRateMagnitude based on slipRate1 and 2 (and not the across interface velocities)

[Thomas-Ulrich]

Please take a look at the comment in the code.
Need to be in-depth tested, but my first tests seem to confirm it works better (no more/less trailing signal).
Any comment is welcome

Thomas.

[davschneller]

You will also need to adjust the GPU port, at around

SeisSol/src/DynamicRupture/FrictionLaws/GpuImpl/BaseFrictionSolver.h

Lines 129 to 136 in ee0a154

	common::computeFrictionEnergy<gpuRangeType>(devEnergyData[ltsFace],
	devQInterpolatedPlus[ltsFace],
	devQInterpolatedMinus[ltsFace],
	devImpAndEta[ltsFace],
	devTimeWeights,
	devSpaceWeights,
	devGodunovData[ltsFace],
	pointIndex);

(i.e. just adding devSlipRateMagnitude there should do it)

[Thomas-Ulrich]

Here is a comparison with the Kaikoura LSW training example:

With a zoom in to the end of the moment rate release

(note that I also increased the precision of the energy output, to be able to better see the difference).

[codecov-commenter]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e941265) 13.99% compared to head (edb5302) 13.99%.

Files	Patch %	Lines
src/ResultWriter/EnergyOutput.cpp	0.00%	4 Missing ⚠️
...DynamicRupture/FrictionLaws/FrictionSolverCommon.h	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   13.99%   13.99%           
=======================================
  Files         266      266           
  Lines       14886    14885    -1     
=======================================
  Hits         2083     2083           
+ Misses      12803    12802    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.