Carsten/comm proxy #979
Carsten/comm proxy #979
Conversation
Signed-off-by: Carsten Uphoff <carsten.uphoff@intel.com>
uphoffc
force-pushed
the
carsten/comm-proxy
branch
from
f8ca99a
to
3e47ac5
Compare
| cmake_minimum_required(VERSION 3.13) | ||
| project(SeisSol-comm-proxy LANGUAGES CXX) | ||
|
|
||
| option(SYCL "Use SYCL to allocate buffers" OFF) |
There was a problem hiding this comment.
Why not make that compile automatically into the program? Also, maybe check for ACL_DEVICE?
|
|
||
| namespace seissol { | ||
|
|
||
| Args ArgParser::parseArgs(int argc, char** argv) { |
There was a problem hiding this comment.
Why not use utils/args.h?
| @@ -0,0 +1,394 @@ | |||
| /* Generated by re2c 2.2 on Thu Oct 19 07:04:58 2023 */ | |||
There was a problem hiding this comment.
Even though it's generated code—I'm not a huge fan of GOTOs. But ok. Btw why not YAML? Or use a submodule for a Json reader? Is that too big/small? If so, then why not Hdf5?
|
|
||
| namespace seissol { | ||
|
|
||
| class SyclAllocator : public Allocator { |
There was a problem hiding this comment.
Why only SYCL? Why not use the Device submodule and make it available for all architectures? The module should support that as well—and it may be closer to the truth when simulating, as SeisSol also uses the Device submodule for everything related to wavepropagation.
| @@ -1,12 +1,13 @@ | |||
| #include <Parallel/MPI.h> | |||
| #include "Solver/time_stepping/AbstractGhostTimeCluster.h" | |||
There was a problem hiding this comment.
Have these been formatted? Then maybe add them to the formatting list?
I was looking for a bug related to communication and I thought it would be useful to have a reproducer for the communication part only. I added a reproducer that currently only checks whether communication "works", but I think one could easily extend it to analyze communication performance on a large number of nodes.
In order to use it one has to run SeisSol with "DumpLocalTimeSteppingStructure=1" in the Output section. SeisSol then writes a JSON dump of the MeshStructure and TimeStepping structs. The JSON file is then read into the communication proxy and the MeshStructure thingy is reconstructed. I then re-use the Actor classes in order to orchestrate the communication.