Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update executor image name #8147

Merged
merged 7 commits into from
May 24, 2024
Merged

Conversation

vermakhushboo
Copy link
Member

What does this PR do?

The key name in swoole table becomes too long and generates a warning with the current image name. Replacing it with a shorter name so that key size is within bounds.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's the update to the variables?

@christyjacob4 christyjacob4 dismissed stnguyen90’s stale review May 24, 2024 12:40

Requested changes have been made

@christyjacob4 christyjacob4 merged commit 9f2030f into 1.5.x May 24, 2024
23 checks passed
@christyjacob4 christyjacob4 deleted the chore-rename-executor-image-name branch May 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants