Add notes about ffmpeg, libvlc and soundtouch licenses, fix ffmpeg link. #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces "Commercial usage" with "Closed-source usage" and notes that some components/configuration may change the license of ijkplayer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I am not a lawyer.
The existing references around licensing are incorrect for FFmpeg, and otherwise vague -- so this aims to improve the state of things a little by referencing FFmpeg's licensing documentation.
As far as I can tell, the default behaviour of
ijkplayeris to build with--disable-gpland--disable-nonfree.This also adds links to extra information about VLC and Soundtouch's licensing status, as those projects have specific web pages about it.
While we're here, link to the actual git repository for FFmpeg rather than VLC's mirror.
I came here as the result of poking at some closed-source software which included FFmpeg with
--enable-gplbut only acknowledging the LGPL, and not providing an offer for source code.