解决ijk第一次初始化时异步线程调用主线程造成的线程卡顿问题 #4683

poholo · 2019-04-10T04:00:58Z

修正IJKSDLGLView view调用方式
编译方式去除armv7 armv7s
编译方式用openssl

poholo · 2019-04-10T04:02:49Z

#4681

heelin · 2019-04-18T11:43:25Z

it works! Thanks.

AlekseiR · 2019-05-03T13:01:31Z

Does it fix the memory leak?

poholo · 2019-05-07T02:16:42Z

It hasn't happened yet.

Does it fix the memory leak?

It hasn't happened yet.

FxDepths · 2019-05-09T07:36:32Z

能说的详细一下吗？谢谢

poholo · 2019-05-13T02:21:36Z

能说的详细一下吗？谢谢

这个问题，主要原因是xcode版本升级导致的，UIKit以前非必须主线程调用的(比如.layer ), 现在必须主线程调用，异步线程调用会导致线程检查等待，故本次的修改主要是对IJKSDLGLView中被检查到的UIKit调用全部用主线程调用。

ios/IJKMediaPlayer/IJKMediaPlayer/ijkmedia/ijksdl/ios/IJKSDLGLView.m

a20727740 · 2019-07-17T08:35:55Z

修正IJKSDLGLView视图调用方式

编译方式去除armv7 armv7s

编译方式用的OpenSSL

观看的时候快速seek多次会崩溃 , ...我用官方的没事

poholo · 2019-07-17T08:43:22Z

修正IJKSDLGLView视图调用方式

编译方式去除armv7 armv7s

编译方式用的OpenSSL

观看的时候快速seek多次会崩溃 , ...我用官方的没事

什么机型？用我编译好的framework看看呢？

MCIJKPlayer

a20727740 · 2019-07-17T09:04:11Z

修正IJKSDLGLView视图调用方式

编译方式去除armv7 armv7s

编译方式用的OpenSSL的

观看的时候快速寻求多次会崩溃，...我用官方的没事

什么机型？用我编译好的框架看看呢？

MCIJKPlayer

...用不了. 你确认没发错?IJKMediaFramework.framework

poholo · 2019-07-17T09:07:34Z

修正IJKSDLGLView视图调用方式

编译方式去除armv7 armv7s

编译方式用的OpenSSL的

观看的时候快速寻求多次会崩溃，...我用官方的没事

什么机型？用我编译好的框架看看呢？
MCIJKPlayer

...用不了. 你确认没发错?IJKMediaFramework.framework

https://dev.tencent.com/u/lp_mr/p/MCIJKPlayer/git

a20727740 · 2019-07-17T09:17:09Z

修正IJKSDLGLView视图调用方式

编译方式去除armv7 armv7s

编译方式用的OpenSSL的的

观看的时候快速寻求多次会崩溃，...我用官方的没事

什么机型？用我编译好的框架看看呢？
MCIJKPlayer

......用不了。你确认没发错？IJKMediaFramework.framework

https://dev.tencent.com/u/lp_mr/p/MCIJKPlayer/git

100%复现了, ....

SamPan1988

Hope this will help someone

SamPan1988 · 2019-07-17T09:17:58Z

ios/IJKMediaPlayer/IJKMediaPlayer/ijkmedia/ijksdl/ios/IJKSDLAudioQueueController.m

-    // do not lock AudioQueueStop, or may be run into deadlock
-    AudioQueueStop(_audioQueueRef, true);
-    AudioQueueDispose(_audioQueueRef, true);
+    IJKMainThredExecute(^{


这里会导致野指针崩溃，因AudioQuueueDispose 在主队列的执行时间不确定，可能IJKSDLAudioQueueController的实例已经被释放，但AudioQueueDispose还没执行，导致IJKSDLAudioQueueOuptutCallback回调时访问已释放的IJKSDLAudioQueueController的实例，引起崩溃；

测试场景：
播放资源切换，因为ijkffmoviecontroller的设计，实际上每次播放一个新的资源都是创建一个新的ijkffmoviecontroller的实例

试一试

[self.player stop]; [self.player shutdown];

我也遇到这个问题了，请问解决了么

我今天遇到了这个问题，有解决的吗？

a20727740 · 2019-07-17T09:26:00Z

https://i.loli.net/2019/07/17/5d2ee98cdde3841555.png

a20727740 · 2019-07-17T09:31:26Z

是的, 我是两个 url 之间切换循环, 创建释放 ijk......

希望这会对某人有所帮助

是的, 我是两个 url 之间切换循环, 创建释放 ijk......

poholo · 2019-08-02T08:36:21Z

https://git.dev.tencent.com/lp_mr/MCIJKPlayer.git
已做优化，看看是否还是有同样的问题。

wning13 · 2019-08-02T08:45:42Z

我这边遇到一个问题是播放本地的视频时没有声音，播放进度一直是0

poholo · 2019-08-02T08:49:21Z

多找几个视频地址试一下(看看你手机的媒体音量设置模式等。。)，我没发现这个问题。

a20727740 · 2019-08-03T02:10:59Z

多找几个视频地址试一下（看看你手机的媒体音量设置模式等。），我没发现这个问题。

https://i.loli.net/2019/08/03/dTqfU9hI6riv1Bg.png 显示模式改了?上面是你的下面的默认的

YelCode · 2019-08-28T12:05:21Z

多找几个视频地址试一下(看看你手机的媒体音量设置模式等。。)，我没发现这个问题。

你好你这个显示模式有问题啊视频变得很小

poholo · 2019-08-30T02:16:44Z

图片看不到了，不确定你们是什么问题。

默认也是 IJKMPMovieScalingModeAspectFit

 _scalingMode = IJKMPMovieScalingModeAspectFit;
        _shouldAutoplay = YES;
        memset(&_asyncStat, 0, sizeof(_asyncStat));
        memset(&_cacheStat, 0, sizeof(_cacheStat));
        _monitor = [[IJKFFMonitor alloc] init];

YelCode · 2019-08-31T02:28:47Z

图1是默认框架的IJKMPMovieScalingModeAspectFit 会延伸到屏幕宽度
图2是你的框架IJKMPMovieScalingModeAspectFit 视频缩小了

poholo · 2019-08-31T02:30:48Z

麻烦贴一下视频地址感谢 | | 马建成邮箱：mailjiancheng@163.com | 签名由网易邮箱大师定制在2019年08月31日 10:29，BinHuang 写道：图1是默认框架的IJKMPMovieScalingModeAspectFit 会延伸到屏幕宽度图2是你的框架IJKMPMovieScalingModeAspectFit 视频缩小了 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

YelCode · 2019-08-31T06:14:07Z

随便一个点播的地址都是这样
http://5815.liveplay.myqcloud.com/live/5815_89aad37e06ff11e892905cb9018cf0d4.flv

chaocharleswang · 2019-09-01T20:55:20Z

我的也存在视频图像很小这个问题，测试的所有视频都这样
原版本不存在这个问题
用的scalingMode是.aspectFit

poholo · 2019-09-02T03:28:50Z

这块的问题是子view没有随着父view的frame变化而自适应，源码是demo层做了autoresizingMask，现在我把这句直接提到IJKFFMovieController中。命中语句

self.player.view.autoresizingMask = UIViewAutoresizingFlexibleWidth|UIViewAutoresizingFlexibleHeight;

@YellBinn @chaocharleswang
辛苦可以看一下是否解决，不愿重新打包的话可以调用这么一句试试呢？

当然也可以直接用我打的pod

pod 'MCIJKPlayer'

https://git.dev.tencent.com/lp_mr/MCIJKPlayer.git

poholo · 2019-09-02T03:53:21Z

@chaocharleswang 麻烦贴一下视频地址

chaocharleswang · 2019-09-02T03:58:52Z

@poholo 将才测试时替换出现错误，问题解决了，谢谢！

chaocharleswang · 2019-09-02T04:04:08Z

@poholo 我观察到另外一个问题：视图变小的版本在xcode 10和xcode 11都能正常运行。
而修改后的版本在xcode 11出现下列错误：

-[MTLDebugBuffer newTextureWithDescriptor:offset:bytesPerRow:]:326: failed assertion `resourceOptions (0x0) must match backing buffer resource options (0x20).'

或者

validateNewTexture:89: failed assertion `BytesPerRow of a buffer-backed texture with pixelFormat(MTLPixelFormatBGRA8Unorm) must be aligned to 64 bytes, found bytesPerRow(4512)'

错误都出现在下面的语句：

[_context renderbufferStorage:GL_RENDERBUFFER fromDrawable:(CAEAGLLayer *) self.weakLayer];

错误出现的操作是缩放移动视频播放界面，操作都是在iPhone X上进行的

poholo · 2019-09-02T06:02:13Z

@chaocharleswang 你试试把IJKSDLGLView中304行注释掉看看

_isRenderBufferInvalidated = YES;

其他我没有变动什么

chaocharleswang · 2019-09-02T14:34:21Z

@poholo 注释后问题确实消失了，只不过视图又变回小视图了

poholo · 2019-09-03T02:51:54Z

@chaocharleswang 帮忙验证一下，感谢！

chaocharleswang · 2019-09-03T03:54:40Z

@poholo 视图正常，移动播放窗口xcode 11还是会出现同样的错误，而xcode 10却一切正常

poholo · 2019-09-03T04:00:02Z

@chaocharleswang 我去下个测试版的xcode

chaocharleswang · 2019-09-05T16:25:08Z

@poholo 我把你改过的code整合到我的项目中，用户反馈最多的crash是下面这一个：

Thread 21 name:
Thread 21 Crashed:
0   libGPUSupportMercury.dylib    	0x0000000212b0ffe4 gpus_ReturnNotPermittedKillClient + 12 (gpui_client_io.c:78)
1   AGXGLDriver                   	0x00000002171bced8 glrKillClient + 468 (agxu_kill_client.cpp:175)
2   libGPUSupportMercury.dylib    	0x0000000212b10fac gpusSubmitDataBuffers + 176 (gpui_context.c:0)
3   AGXGLDriver                   	0x00000002171be404 SubmitPackets(AGXContextRec*) + 292 (agxu_gl_command.cpp:93)
4   GLEngine                      	0x00000002183cd234 gliPresentViewES_Exec + 184 (gli_drawable_es.c:526)
5   OpenGLES                      	0x00000001f9d10aa4 -[EAGLContext presentRenderbuffer:] + 80 (eagl_context.m:594)
6   TubePlayer                     	0x0000000100a5da20 -[IJKSDLGLView displayInternal:] + 456 (IJKSDLGLView.m:378)
7   TubePlayer                     	0x0000000100a5d7c0 -[IJKSDLGLView display:] + 204 (IJKSDLGLView.m:340)
8   TubePlayer                     	0x0000000100a6e9b8 vout_display_overlay + 300 (ijksdl_vout_ios_gles2.m:0)
9   TubePlayer                     	0x0000000100a58d30 video_display2 + 348 (ff_ffplay.c:911)
10  TubePlayer                     	0x0000000100a56ec4 video_refresh_thread + 1868 (ff_ffplay.c:1416)
11  TubePlayer                     	0x0000000100a5b130 SDL_RunThread + 40 (ijksdl_thread_ios.m:32)
12  libsystem_pthread.dylib       	0x00000001f67242c0 _pthread_body + 128 (pthread.c:857)
13  libsystem_pthread.dylib       	0x00000001f6724220 _pthread_start + 44 (pthread.c:884)
14  libsystem_pthread.dylib       	0x00000001f6727cdc thread_start + 4

这是通过xcode 10提交的，和xcode 11无关
还有一个crash是下面这一个，这一个反馈的少一些：

Thread 0 Crashed:
0   libsystem_kernel.dylib        	0x00000002355590cc __pthread_kill + 8
1   libsystem_c.dylib             	0x00000002354b214c abort + 144 (abort.c:94)
2   libsystem_c.dylib             	0x000000023547f2d0 __assert_rtn + 316 (assert.c:91)
3   TubePlayer                     	0x0000000101262c0c ffp_prepare_async_l + 2016 (ff_ffplay.c:4252)
4   TubePlayer                     	0x0000000101271174 ijkmp_prepare_async + 332 (ijkplayer.c:413)
5   TubePlayer                     	0x000000010113609c thunk for @escaping @callee_guaranteed () -> () + 28 (<compiler-generated>:0)
6   libdispatch.dylib             	0x00000002353d4308 _dispatch_call_block_and_release + 32 (init.c:1372)
7   libdispatch.dylib             	0x00000002353d5888 _dispatch_client_callout + 20 (object.m:511)
8   libdispatch.dylib             	0x00000002353e173c _dispatch_main_queue_callback_4CF + 1012 (inline_internal.h:2441)
9   CoreFoundation                	0x0000000235956734 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 16 (CFRunLoop.c:1813)
10  CoreFoundation                	0x00000002359513e4 __CFRunLoopRun + 1888 (CFRunLoop.c:3113)
11  CoreFoundation                	0x0000000235950964 CFRunLoopRunSpecific + 452 (CFRunLoop.c:3247)
12  GraphicsServices              	0x0000000237b91d8c GSEventRunModal + 108 (GSEvent.c:2245)
13  UIKitCore                     	0x0000000262ded758 UIApplicationMain + 216 (UIApplication.m:4353)
14  TubePlayer                     	0x0000000100f24134 main + 68 (FilterViewController.swift:18)
15  libdyld.dylib                 	0x000000023540cfd8 start + 4

poholo · 2019-09-06T02:05:42Z

嗯，多少的崩溃率？在 2019-09-06 00:25:27，"Charles" <notifications@github.com> 写道： @poholo 我把你改过的code整合到我的项目中，用户反馈最多的错误是下面这一个： Thread 21 name: Thread 21 Crashed: 0 libGPUSupportMercury.dylib 0x0000000212b0ffe4 gpus_ReturnNotPermittedKillClient + 12 (gpui_client_io.c:78) 1 AGXGLDriver 0x00000002171bced8 glrKillClient + 468 (agxu_kill_client.cpp:175) 2 libGPUSupportMercury.dylib 0x0000000212b10fac gpusSubmitDataBuffers + 176 (gpui_context.c:0) 3 AGXGLDriver 0x00000002171be404 SubmitPackets(AGXContextRec*) + 292 (agxu_gl_command.cpp:93) 4 GLEngine 0x00000002183cd234 gliPresentViewES_Exec + 184 (gli_drawable_es.c:526) 5 OpenGLES 0x00000001f9d10aa4 -[EAGLContext presentRenderbuffer:] + 80 (eagl_context.m:594) 6 TubePlayer 0x0000000100a5da20 -[IJKSDLGLView displayInternal:] + 456 (IJKSDLGLView.m:378) 7 TubePlayer 0x0000000100a5d7c0 -[IJKSDLGLView display:] + 204 (IJKSDLGLView.m:340) 8 TubePlayer 0x0000000100a6e9b8 vout_display_overlay + 300 (ijksdl_vout_ios_gles2.m:0) 9 TubePlayer 0x0000000100a58d30 video_display2 + 348 (ff_ffplay.c:911) 10 TubePlayer 0x0000000100a56ec4 video_refresh_thread + 1868 (ff_ffplay.c:1416) 11 TubePlayer 0x0000000100a5b130 SDL_RunThread + 40 (ijksdl_thread_ios.m:32) 12 libsystem_pthread.dylib 0x00000001f67242c0 _pthread_body + 128 (pthread.c:857) 13 libsystem_pthread.dylib 0x00000001f6724220 _pthread_start + 44 (pthread.c:884) 14 libsystem_pthread.dylib 0x00000001f6727cdc thread_start + 4 这是通过xcode 10提交的，和xcode 11无关 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

chaocharleswang · 2019-09-06T02:28:43Z

@poholo 现在有的数据是前者和后者之间相比为15：1

mengzhe360 · 2019-09-06T03:51:38Z

https://git.dev.tencent.com/lp_mr/MCIJKPlayer.git
已做优化，看看是否还是有同样的问题。

请问作者这个能支持播放https 和MP4格式的么

poholo · 2019-09-06T03:56:11Z

支持，编译加了openssl库在 2019-09-06 11:51:58，"mengzhe360" <notifications@github.com> 写道： https://git.dev.tencent.com/lp_mr/MCIJKPlayer.git 已做优化，看看是否还是有同样的问题。请问作者这个能支持播放https 和MP4格式的么 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

mengzhe360 · 2019-09-06T05:36:38Z

感谢回复 | | mengzhe360 | | mengzhe360@163.com | 签名由网易邮箱大师定制在2019年09月6日 11:57，littleplayer<notifications@github.com> 写道：支持，编译加了openssl库在 2019-09-06 11:51:58，"mengzhe360" <notifications@github.com> 写道： https://git.dev.tencent.com/lp_mr/MCIJKPlayer.git 已做优化，看看是否还是有同样的问题。请问作者这个能支持播放https 和MP4格式的么 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

mengzhe360 · 2019-09-06T06:47:53Z

请问只要滑动一点播放屏幕直接就停止播放了，上面的是打印的日志，直接关闭播放器了，请问这个情况遇到怎么解 | | mengzhe360 | | mengzhe360@163.com | 签名由网易邮箱大师定制在2019年09月6日 11:57，littleplayer<notifications@github.com> 写道：支持，编译加了openssl库在 2019-09-06 11:51:58，"mengzhe360" <notifications@github.com> 写道： https://git.dev.tencent.com/lp_mr/MCIJKPlayer.git 已做优化，看看是否还是有同样的问题。请问作者这个能支持播放https 和MP4格式的么 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

panzhenAlex

更改player的frame 会crash

poholo · 2019-12-03T07:52:20Z

https://github.com/poholo/MCPlayerKit 用这个测试一下

mengzhe360 · 2019-12-05T08:18:12Z

謝謝回復，非常感謝啊 | | mengzhe360 | | mengzhe360@163.com | 签名由网易邮箱大师定制在2019年12月3日 15:52，littleplayer<notifications@github.com> 写道： https://github.com/poholo/MCPlayerKit 用这个测试一下 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

iOS -- ssl -- thread

ae5c11d

poholo mentioned this pull request Apr 10, 2019

XCode 9: Main Thread Checker: UI API called on a background thread: -[UIView layer] #3592

Open

wning13 reviewed May 16, 2019

View reviewed changes

ios/IJKMediaPlayer/IJKMediaPlayer/ijkmedia/ijksdl/ios/IJKSDLGLView.m Outdated Show resolved Hide resolved

poholo added 2 commits May 17, 2019 14:32

优化线程逻辑~

5c9802d

优化线程逻辑~

280a5a0

This was referenced May 17, 2019

fix block UI thread #4712

Closed

armv7a 编译出错问题 #4735

Open

armv5 编译出错问题 #4736

Open

baishuai mentioned this pull request May 25, 2019

ios: IJKSDLGLView fix xcode 10.2.1 Main Thread Checker issues #4739

Closed

修正编译参数

90ab70b

SamPan1988 reviewed Jul 17, 2019

View reviewed changes

fix crash

2a591c9

fix: 增加GLView是的autoresing到IJKFFMoviePlayerController

8764676

fix: 关闭画布旋转、初始化的线程切换

972d2a1

panzhenAlex reviewed Nov 27, 2019

View reviewed changes

poholo mentioned this pull request Oct 18, 2021

淦，到底IJKSDLGLView主线程崩溃问题怎么才能够解决呀，网上说的都试过 #5339

Open

解决ijk第一次初始化时异步线程调用主线程造成的线程卡顿问题 #4683

Are you sure you want to change the base?

解决ijk第一次初始化时异步线程调用主线程造成的线程卡顿问题 #4683

Conversation

poholo commented Apr 10, 2019

poholo commented Apr 10, 2019

heelin commented Apr 18, 2019

AlekseiR commented May 3, 2019

poholo commented May 7, 2019

FxDepths commented May 9, 2019

poholo commented May 13, 2019

a20727740 commented Jul 17, 2019

poholo commented Jul 17, 2019

a20727740 commented Jul 17, 2019

poholo commented Jul 17, 2019

a20727740 commented Jul 17, 2019

SamPan1988 left a comment

Choose a reason for hiding this comment

SamPan1988 Jul 17, 2019

Choose a reason for hiding this comment

SamPan1988 Jul 17, 2019

Choose a reason for hiding this comment

Han2L Jul 30, 2019

Choose a reason for hiding this comment

mengzhe360 Sep 6, 2019

Choose a reason for hiding this comment

qing-song Dec 25, 2020

Choose a reason for hiding this comment

a20727740 commented Jul 17, 2019

a20727740 commented Jul 17, 2019

poholo commented Aug 2, 2019

wning13 commented Aug 2, 2019

poholo commented Aug 2, 2019

a20727740 commented Aug 3, 2019

YelCode commented Aug 28, 2019

poholo commented Aug 30, 2019

YelCode commented Aug 31, 2019

poholo commented Aug 31, 2019 via email

YelCode commented Aug 31, 2019

chaocharleswang commented Sep 1, 2019 • edited

poholo commented Sep 2, 2019 • edited

poholo commented Sep 2, 2019

chaocharleswang commented Sep 2, 2019

chaocharleswang commented Sep 2, 2019 • edited

poholo commented Sep 2, 2019

chaocharleswang commented Sep 2, 2019

poholo commented Sep 3, 2019

chaocharleswang commented Sep 3, 2019

poholo commented Sep 3, 2019

chaocharleswang commented Sep 5, 2019 • edited

poholo commented Sep 6, 2019 via email

chaocharleswang commented Sep 6, 2019

mengzhe360 commented Sep 6, 2019

poholo commented Sep 6, 2019 via email

mengzhe360 commented Sep 6, 2019 via email

mengzhe360 commented Sep 6, 2019 via email

panzhenAlex left a comment

Choose a reason for hiding this comment

poholo commented Dec 3, 2019

mengzhe360 commented Dec 5, 2019 via email

chaocharleswang commented Sep 1, 2019 •

edited

poholo commented Sep 2, 2019 •

edited

chaocharleswang commented Sep 2, 2019 •

edited

chaocharleswang commented Sep 5, 2019 •

edited