[localization] Gracefully handle unsupported locales #28902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleqsio
requested review from
tsapeta and
behenate
and removed request for
EvanBacon
behenate
approved these changes
May 16, 2024
tsapeta
approved these changes
May 16, 2024
| null; // using 1e5 instead of 1e4 since for some locales (like pl-PL) 1e4 does not use digit grouping | ||
| const decimalSeparator = (1.1).toLocaleString(languageTag).substring(1, 2); | ||
| const temperatureUnit = region ? regionToTemperatureUnit(region) : null; | ||
| let digitGroupingSeparator: string | null = null; |
There was a problem hiding this comment.
I'm not a big fan of using let/var and reassignments, but ok 🤷♂️
tsapeta
changed the title
aleqsio
force-pushed
the
fix/unsupported-locale
branch
from
d1a6103
to
c8ea8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is a PR by @mary-ext, just linted and rebuilt.
#27403
Closes #25694
I'm unable to push changes to that fork, so made a new PR
How
Test Plan
Tested that this doesn't break working locales on web.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).