[video] Add isLive property for Android, iOS and Web. #28903
Merged
+39
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustJoostNL
requested review from
Simek,
amandeepmittal,
tsapeta and
aleqsio
as code owners
expo-bot
added
bot: suggestions
aleqsio
reviewed
May 20, 2024
| @@ -137,6 +139,7 @@ class VideoPlayer(context: Context, appContext: AppContext, source: VideoSource? | |||
| } | |||
| if (playbackState == Player.STATE_READY) { | |||
There was a problem hiding this comment.
shouldn't this have some sort of undefined state while the media item is loading? Are we making it explicit that you should not check this while the state is not ready?
There was a problem hiding this comment.
@aleqsio I don't know if adding a special state while the media is loading isn't a bit overkill. I think we can just set it to false.
behenate
approved these changes
May 20, 2024
There was a problem hiding this comment.
@aleqsio I think it's a good addition, especially for people who will be creating their own UI controls on the JS side
@JustJoostNL Thanks for another contribution!
tsapeta
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Expo-video doesn't have any way to check if a video is a livestream.
How
I added the isLive property on all platforms. For Web and iOS it checks if the duration is infinite, which means the video is a live stream. For Android it uses
isCurrentMediaItemLive.Test Plan
Tested using bare-expo.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).