Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osascript] refactor deprecated util.isArray #28927

Merged
merged 5 commits into from
May 19, 2024
Merged

[osascript] refactor deprecated util.isArray #28927

merged 5 commits into from
May 19, 2024

Conversation

hirbod
Copy link
Contributor

@hirbod hirbod commented May 16, 2024

Why

(node:4385) [DEP0044] DeprecationWarning: The util.isArray API is deprecated. Please use Array.isArray() instead.

This is done in preparation for Node 22 (Array.isArray is available in Node 10+)

How

Changed util.isArray to Array.isArray. I did not remove the util import, as other util functions are still in use.

Test Plan

Checklist

> (node:4385) [DEP0044] DeprecationWarning: The `util.isArray` API is deprecated. Please use `Array.isArray()` instead.

In preparation for Node 22 (Array.isArray is available in Node 10+)
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 16, 2024
hirbod and others added 2 commits May 16, 2024 15:39
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@hirbod hirbod requested a review from expo-bot May 16, 2024 14:40
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 16, 2024
@Simek Simek requested a review from EvanBacon May 16, 2024 15:13
@Simek Simek changed the title refactor: util.isArray is deprecated [osascript] refactor deprecated util.isArray May 16, 2024
@Simek
Copy link
Collaborator

Simek commented May 16, 2024

Hey @hirbod, can you also rebuild the package files?

@hirbod
Copy link
Contributor Author

hirbod commented May 17, 2024

@Simek done

@Simek Simek merged commit 9ae1cb6 into expo:main May 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants