Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(env,cli): stale env variables after env files change #28935

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(env,cli): stale env variables after env files change #28935

wants to merge 2 commits into from
+86 −1

Conversation

XantreDev
Copy link

@XantreDev XantreDev commented May 16, 2024 •
edited

Why

Expo cli do not respond on env file update
#28891

How

Started to clean up env vars before using dotenvExtend

Test Plan

I wrote unit test env is updated

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 16, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBacon EvanBacon Awaiting requested review from EvanBacon EvanBacon is a code owner

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XantreDev @expo-bot