Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][Android] Removed unneeded in-between function call when resolving promise without arguments #28944

Merged
merged 2 commits into from
May 18, 2024

Conversation

lukmccall
Copy link
Contributor

Why

Removes unneeded in-between function call when resolving promise without arguments

Test Plan

  • tests ✅

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 17, 2024
@expo-bot
Copy link
Collaborator

The Pull Request introduced fingerprint changes against the base commit: a1d0edf

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "f1cac92a1fbe0c9d9772c6e9f2ea973a8e46e76b"
  }
]

Generated by PR labeler 🤖

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@lukmccall lukmccall merged commit 326b840 into main May 18, 2024
3 checks passed
@lukmccall lukmccall deleted the @lukmccall/core/remove-in-between-function-call branch May 18, 2024 16:15
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants