-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] introduce Expo package API reference page #28945
Conversation
The Pull Request introduced fingerprint changes against the base commit: 9ae1cb6 Fingerprint diff[
{
"type": "dir",
"filePath": "../../node_modules/expo",
"reasons": [
"bareRncliAutolinking"
],
"hash": "380d87060ef549a5b26c0cb313192f296230e574"
},
{
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins"
],
"hash": "c7873af682994bd9687e08e7ca584adf565ab983"
},
{
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "b6675d89e48b2a5933a3f5100a1fc35cca27204c"
}
] Generated by PR labeler 🤖 |
📘 Your docs preview website is ready! |
docs/pages/versions/unversioned/sdk/register-root-component.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
that's great one. thanks for bringing this doc. |
Why
So far, we have only exposed the docs for one exported method from main
expo
which wasregisterRootComponent
.Also fixes ENG-12111
How
This PR adds the page including the methods and types exported from main
expo
package. In the future, it should be the great place for exposing more common code shared between the packages likePermissionsResponse
,Subscription
or other common elements which we re-export in package code from the dependencies.I have also removed the
registerRootComponent
to avoid listing the same information twice. The changes have been only applied tounversioned
docs.Test Plan
The changes have been reviewed locally. ALl lint checks and tests are passing.
Preview