-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch exported EventEmitter to the C++ implementation #28946
Merged
Merged
+2,043
−2,011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pull Request introduced fingerprint changes against the base commit: 025f63f Fingerprint diff[
{
"type": "dir",
"filePath": "../../node_modules/expo",
"reasons": [
"bareRncliAutolinking"
],
"hash": "e1210adc8e3b158a03f1c78a63901e403cfe5bc9"
},
{
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins"
],
"hash": "f791cd1726404fa85442b32e12047368d6e90818"
},
{
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "16e8fe388df60d874ff08162b0962b2d3fa5f158"
},
{
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "eff67da5a285006dc532eb299cde08e2b7576cbb"
}
] Generated by PR labeler 🤖 |
tsapeta
force-pushed
the
@tsapeta/core/remove-legacy-event-emitter
branch
2 times, most recently
from
May 18, 2024 08:27
72ab8a4
to
c873630
Compare
tsapeta
changed the title
[core] Remove legacy EventEmitter class
Switch exported EventEmitter to the C++ implementation
May 18, 2024
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
May 18, 2024
tsapeta
force-pushed
the
@tsapeta/core/remove-legacy-event-emitter
branch
from
May 18, 2024 09:51
64e8aa0
to
47fad1c
Compare
tsapeta
requested review from
ide,
brentvatne,
wschurman,
douglowder,
byCedric,
Kudo,
alanjhughes,
lukmccall,
EvanBacon,
aleqsio and
gabrieldonadel
as code owners
May 19, 2024 08:16
tsapeta
removed request for
brentvatne,
wschurman,
ide,
byCedric,
aleqsio,
douglowder,
EvanBacon,
gabrieldonadel and
alanjhughes
May 19, 2024 08:16
lukmccall
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I'm switching the exported EventEmitter from the legacy JS implementation to the new one in C++. The previous one will be exported as LegacyEventEmitter and still used in some modules that were not migrated to Expo Modules API (in this case the module object is not an instance of the C++ emitter).
It also renames
Subscription
type to a more meaningfulEventSubscription
. I'm intentionally not renaming how the type is re-exported by other packages so I don't introduce a breaking change yet – eventually this type shouldn't be re-exported at all, instead be a common type exported from theexpo
package.Test Plan
I went through tests and examples of the modules I changed.