[web][camera] Fix missing function "getCapabilities" in Firefox #28947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
reviewed
May 17, 2024
miso-belica
force-pushed
the
fix/firefox-get-capabilities-not-function
branch
from
5cd0293
to
91dc7b6
Compare
expo-bot
added
bot: passed checks
|
Yes, sure. Sorry it took a while. I hope it OK now. |
lukmccall
reviewed
May 21, 2024
lukmccall
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As explained in #13182 Firefox freezes when this happens which is quite annoying.
How
I skip calling the affected function entirely. It would result having no effect anyway of I pretend to have no capabilities.
Test Plan
All details were already provided in #13182
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).