Kotlinize CSSBackgroundDrawable #44543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57250729 |
Base commit: a37111a |
|
This pull request was exported from Phabricator. Differential Revision: D57250729 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 12, 2024
Summary: Pull Request resolved: facebook#44543 This looked like starting with Android Studio Kotlinizer output, then fixing compilation errors, then lint warnings about naming (where previous member variables are shadowing), and finally getting rid of null warnings by using `let? {}` blocks, and a pattern akin to JS `??=`, in more places Lots of opportunities for cleanup still here. Changelog: [Internal] Differential Revision: D57250729
NickGerleman
force-pushed
the
export-D57250729
branch
from
ab1c778
to
5ba6ce4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57250729 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 16, 2024
Summary: Pull Request resolved: facebook#44543 This looked like starting with Android Studio Kotlinizer output, then fixing compilation errors, then lint warnings about naming (where previous member variables are shadowing), and finally getting rid of null warnings by using `let? {}` blocks, and a pattern akin to JS `??=`, in more places Lots of opportunities for cleanup still here. Changelog: [Internal] Reviewed By: rshest Differential Revision: D57250729
NickGerleman
force-pushed
the
export-D57250729
branch
from
5ba6ce4
to
d4a67c6
Compare
Summary: I didn't pay close enough attention resolving merge in between V1 to V2 of D57248205, and what I ultimately checked in was not correct. Fix the logic here. Changelog: [Internal] Differential Revision: D57488372
…id] Propagate layout direction to Android views Differential Revision: D57248417
Summary: Changelog: Internal Differential Revision: D57250750
Summary: Pull Request resolved: facebook#44543 This looked like starting with Android Studio Kotlinizer output, then fixing compilation errors, then lint warnings about naming (where previous member variables are shadowing), and finally getting rid of null warnings by using `let? {}` blocks, and a pattern akin to JS `??=`, in more places Lots of opportunities for cleanup still here. Changelog: [Internal] Reviewed By: rshest Differential Revision: D57250729
|
This pull request was exported from Phabricator. Differential Revision: D57250729 |
NickGerleman
force-pushed
the
export-D57250729
branch
from
d4a67c6
to
f1a78bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This looked like starting with Android Studio Kotlinizer output, then fixing compilation errors, and lint warnings about naming (where previous member variables are shadowing).
Lots of opportunities for cleanup still here.
Changelog: [Internal]
Differential Revision: D57250729