[Impeller] Distorted text in Cupertino dialog #148588
Assignees
Labels
a: typography
Text rendering, possibly libtxt
c: regression
It was better in the past than it is now
c: rendering
UI glitches reported at the engine/skia rendering level
e: impeller
Impeller rendering backend issues and features requests
found in release: 3.22
Found to occur in 3.22
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
P1
High-priority issues at the top of the work list
team-engine
Owned by Engine team
triaged-engine
Triaged by Engine team
Comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
The issue can be reproducible with this simple example only needing any context. In Flutter version 3.19.6, everything works fine, but in version 3.22.0, this distortion occurs.
I am using an real device, iPhone 15 - iOS 17.4 |
|
Reproducible on the latest stable & master. In my testing, this reproduced only with
code sampleimport 'package:flutter/cupertino.dart';
/// Flutter code sample for [showCupertinoDialog].
void main() => runApp(const CupertinoDialogApp());
class CupertinoDialogApp extends StatelessWidget {
const CupertinoDialogApp({super.key});
@override
Widget build(BuildContext context) {
return const CupertinoApp(
theme: CupertinoThemeData(brightness: Brightness.light),
restorationScopeId: 'app',
home: CupertinoDialogExample(),
);
}
}
class CupertinoDialogExample extends StatelessWidget {
const CupertinoDialogExample({super.key});
@override
Widget build(BuildContext context) {
return CupertinoPageScaffold(
navigationBar: const CupertinoNavigationBar(
middle: Text('Home'),
),
child: Center(
child: CupertinoButton(
onPressed: () {
Navigator.of(context).restorablePush(_dialogBuilder);
},
child: const Text('Open Dialog'),
),
),
);
}
@pragma('vm:entry-point')
static Route<Object?> _dialogBuilder(
BuildContext context, Object? arguments) {
return CupertinoDialogRoute<void>(
context: context,
builder: (BuildContext context) {
return CupertinoAlertDialog(
title: Text('A A A A A A A'),
// content: const Text('Content'),
actions: <Widget>[
CupertinoDialogAction(
onPressed: () {
Navigator.pop(context);
},
child: const Text('Yes'),
),
CupertinoDialogAction(
onPressed: () {
Navigator.pop(context);
},
child: const Text('No'),
),
],
);
},
);
}
}flutter doctor -v |
danagbemava-nc
added
c: regression
danagbemava-nc
changed the title
jonahwilliams
added
P1
|
I just checked against 8eba63f29b8b26931496807cb4fc2fed8e4e3258 and it looks fine.
I also just checked b6971cdf14 and it looks fine. I'm having some technical issues right now but I'll see if I can bisect since this might be the sort of thing we'd want to cherry-pick. |
|
I've tried to reproduce it with the steps at #148588 (comment) engine version: f6344b75dcf861d8bf1f1322780b8811f982e31a The output looks fine on an iPhone SE 2022 The screenshot in the description is of the Simulator, is this a Simulator only bug? |
|
@gaaclarke no, real device is also affected |
|
I'm able to reproduce it on the iPhone 15 Pro simulator at f6344b75dcf861d8bf1f1322780b8811f982e31a. Maybe it's particular to that device. |
|
could be screen size. / dimensions |
|
Its probably the round out. @bdero just relanded that in flutter/engine#52973 |
|
I verified that flutter/engine#52973 did fix this issue, thanks @bdero. |
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
MaterialApp.routershowAdaptiveDialogfunctionifthat explicitly usesCupertinoAlertDialogbecause the contents of the dialog requires an input so I useCupertinoTextFieldas wellAlertDialog.adaptive()callExpected results
Fonts should not look distorted
Actual results
Fonts in
Cupertinostyled dialogs are distorted: titles, dialog actions and even the border ofCupertinoTextFieldalso looks distorted.Code sample
Code sample
Screenshots or Video
Screenshots / Video demonstration
Logs
Logs
nothing suspicious in logsFlutter Doctor output
Doctor output
The text was updated successfully, but these errors were encountered: