[Impeller] Pixel align subpass textures. #52973
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
See also: flutter/flutter#145180 The round out caused flutter/flutter#144213 . But maybe we should have fixed that bug elsewhere? |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Hmm, there is a slightly different way I could fix this that wouldn't make that issue worse. Trying it out now. |
|
Pushed the change. We can just round the texture position instead of modifying the coverage. This will keep the texture edges the same and avoid resurfacing flutter/flutter#144213. |
bdero
force-pushed
the
bdero/fix-layer-bounds
branch
from
78b5d67
to
0d50813
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden changes are looking as expected. |
bdero
changed the title
…148819) flutter/engine@c89defa...b6971cd 2024-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HHwlAJN5imwf3yX4i... to gWBn6yPljFeQvPSYz... (flutter/engine#52975) 2024-05-22 bdero@google.com [Impeller] Round out subpass coverage. (flutter/engine#52973) 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 968e971e438e to 78069713e02a (1 revision) (flutter/engine#52974) 2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ac30bbc63e to fca7dd796e81 (1 revision) (flutter/engine#52972) 2024-05-21 ditman@gmail.com [web] Adds Noto Serif Tibetan fallback font. (flutter/engine#52971) 2024-05-21 magder@google.com Update file permissions for FlutterMacOS.framework bundle (flutter/engine#52961) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HHwlAJN5imwf to gWBn6yPljFeQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#148819) flutter/engine@c89defa...b6971cd 2024-05-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HHwlAJN5imwf3yX4i... to gWBn6yPljFeQvPSYz... (flutter/engine#52975) 2024-05-22 bdero@google.com [Impeller] Round out subpass coverage. (flutter/engine#52973) 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 968e971e438e to 78069713e02a (1 revision) (flutter/engine#52974) 2024-05-21 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ac30bbc63e to fca7dd796e81 (1 revision) (flutter/engine#52972) 2024-05-21 ditman@gmail.com [web] Adds Noto Serif Tibetan fallback font. (flutter/engine#52971) 2024-05-21 magder@google.com Update file permissions for FlutterMacOS.framework bundle (flutter/engine#52961) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HHwlAJN5imwf to gWBn6yPljFeQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
added
the
cp: stable
|
Failed to create CP due to merge conflicts. |
Resolves flutter/flutter#146967 I added a detailed comment inline explaining why we need this. The visual issues in the reported issue were due to nearest sampling while straddling a half pixel offset. Before:  After: <img width="964" alt="image" src="https://github.com/flutter/engine/assets/919017/0be88453-1014-443b-bc80-6df459adb075">
Resolves flutter/flutter#146967 I added a detailed comment inline explaining why we need this. The visual issues in the reported issue were due to nearest sampling while straddling a half pixel offset. Before:  After: <img width="964" alt="image" src="https://github.com/flutter/engine/assets/919017/0be88453-1014-443b-bc80-6df459adb075">
Resolves flutter/flutter#146967
I added a detailed comment inline explaining why we need this. The visual issues in the reported issue were due to nearest sampling while straddling a half pixel offset.
Before:
After:
