Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for future_builder.0.dart #148453

Conversation

ValentinVignal
Copy link
Contributor

Contributes to #130459

It adds a test for

  • examples/api/lib/widgets/async/future_builder.0.dart

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 16, 2024
@ValentinVignal ValentinVignal force-pushed the flutter/api/example/Add-test-to-future-builder branch from 5975ab7 to 567a259 Compare May 16, 2024 04:58
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_log.txt file doesn't seem to belong in this PR

@ValentinVignal
Copy link
Contributor Author

test_log.txt file doesn't seem to belong in this PR

Oops very sorry about that! This should be good now

Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label May 27, 2024
@auto-submit auto-submit bot merged commit 1efca65 into flutter:master May 27, 2024
137 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 27, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 27, 2024
flutter/flutter@6564471...0b31ffc

2024-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 451480f2bf66 to dcc063c8deae (1 revision) (flutter/flutter#149125)
2024-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 76f5849eec5d to 451480f2bf66 (1 revision) (flutter/flutter#149123)
2024-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b92f87cb5c1 to 76f5849eec5d (1 revision) (flutter/flutter#149121)
2024-05-27 32538273+ValentinVignal@users.noreply.github.com Add test for future_builder.0.dart (flutter/flutter#148453)
2024-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from 469193ef0e9a to 2b92f87cb5c1 (1 revision) (flutter/flutter#149119)
2024-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from e91fbacde56d to 469193ef0e9a (1 revision) (flutter/flutter#149114)
2024-05-27 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3025ae1511b to e91fbacde56d (1 revision) (flutter/flutter#149101)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
Contributes to flutter#130459

It adds a test for
- `examples/api/lib/widgets/async/future_builder.0.dart`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants