Fix `Slider` throws an error when `_labelPainter` text is null #148462

hello-coder-xu · 2024-05-16T06:32:09Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter/lib/src/material/slider_theme.dart

…-coder-xu/flutter into fix/slider_text_null_error * 'fix/slider_text_null_error' of https://github.com/hello-coder-xu/flutter: (65 commits) Change implementation method fix slider text null error Make FileSystem dependency explicit througout (more). (flutter#148095) Remove add-to-app bitcode warning (flutter#148587) SelectionArea's selection should not be cleared on loss of window focus (flutter#148067) [wiki migration] Engine team pages (flutter#148696) Manual roll camera dependency (flutter#148426) [wiki migration] Framework team pages (flutter#148721) Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter#148722) Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter#148715) Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter#148714) Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter#148580) Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter#148700) Remove the no-shuffle tag on the flutter_tools create_test suite (flutter#148688) log incoming vm service messages in `FlutterVMService::runInView` (flutter#148596) Add tests for shared_app_data.#.dart API examples. (flutter#147830) Add tests for logical_key_set.0.dart API example. (flutter#147735) [wiki migration] Ecosystem team pages (flutter#148589) Fix painting API examples tests directories structure. (flutter#148177) fixes `CupertinoModalPopupRoute` (flutter#147823) ...

packages/flutter/lib/src/material/slider.dart

packages/flutter/test/material/slider_theme_test.dart

* master: (29 commits) Add tests for actions.0.dart API example. (flutter#148678) Introduce `WidgetStateBorderSide.lerp` (flutter#148122) add `default-flavor` field to flutter pubspec, which will be used as the flavor in `flutter build/run` if `--flavor` is not provided (flutter#147968) [wiki migration] Pages under docs/postmortems/ (flutter#148798) Roll Flutter Engine from e5a73e520e89 to c89defa55801 (2 revisions) (flutter#148812) Make hover tests functional and cleanup mouse pointers in Material toggleables (flutter#148808) Fix two dimensional viewport unexpected null exception when no child is laid out (flutter#148256) Roll Flutter Engine from bc1345b6b50a to e5a73e520e89 (3 revisions) (flutter#148807) Add test for undo_history_controller.0.dart (flutter#148205) Roll Flutter Engine from a8872c8915a2 to bc1345b6b50a (6 revisions) (flutter#148802) Fix test that leaks images. (flutter#148494) Fix warnings in `dependency_version_checker.gradle.kts` (flutter#148699) [wiki migration] Android team pages (flutter#148585) Fix leaky test. (flutter#148788) Add DropdownButton.menuWidth (flutter#148125) Add test for focus example 2 (flutter#147624) Add a migrator to remove `FlutterMultiDexApplication.java` (flutter#148515) [wiki migration] Infra team pages (flutter#148718) Roll Flutter Engine from 8a352f01e503 to a8872c8915a2 (1 revision) (flutter#148776) Fix the output of the CDN test. (flutter#148730) ...

hello-coder-xu · 2024-05-23T01:31:39Z

I updated

packages/flutter/test/material/slider_theme_test.dart

TahaTesser

extra space

packages/flutter/lib/src/material/slider_theme.dart

TahaTesser

LGTM!

Piinks · 2024-05-28T23:41:55Z

packages/flutter/test/material/slider_test.dart

+    debugDisableShadows = false;
+    double sliderValue = 10;
+
+    try {


Why is this in a try block? This can lead to uncaught errors or failures in tests.

This is to ensure that debugDisableShadows is restored to its initial value to avoid affecting other test cases.

This seems to be duplicated from other tests in the slider_test.dart.

Hmm, looking at other tests using debugDisableShadows, it does not appear necessary to use try/finally. Some use a tearDown, some just set it to false at the end of the test. Could you remove the try block here? We can file an issue to remove the others in the test file. I've seen try blocks become sneaky false positive culprits in tests multiple times. I think it's best to avoid if we can. :)

* master: (115 commits) Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) (flutter#149291) disable Impeller on external texture test. (flutter#149292) Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) (flutter#149290) Update 3.22.1 release notes to include missing fix. (flutter#148999) Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) (flutter#149263) Reverts "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149279) Unskip expression evaluation test (flutter#149253) temporarily disable SemanticsAction tests to unblock engine change (flutter#149274) Adds benchmark for rrect_blur. (flutter#149261) Prevent LayoutBuilder from rebuilding more than once (flutter#147856) Add test for inherited_theme.0.dart (flutter#149120) Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS (flutter#145246) _ModalScopeStatus as InheritedModel (flutter#149022) Add test for radio.toggleable.0.dart (flutter#149153) Add a sentinel value for `TextStyle.height` (flutter#149049) Remove dynamic_layouts from issue template (flutter#149252) Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) (flutter#149255) Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) (flutter#149249) Roll Packages from a933c3016f6c to 31d332900d98 (6 revisions) (flutter#149246) Clean leak in editable_text_test.dart. (flutter#149223) ...

Piinks

LGTM thank you!

…ull (flutter/flutter#148462)

…er#148462) *Fix flutter#148159*

flutter/flutter@c85fa6a...7eebe29 2024-05-30 engine-flutter-autoroll@skia.org Roll Packages from 31d3329 to 910fabb (11 revisions) (flutter/flutter#149321) 2024-05-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb64b9a4e6f2 to 2fedfd3cc6e5 (2 revisions) (flutter/flutter#149320) 2024-05-30 yinxulolol@gmail.com Fix `Slider` throws an error when `_labelPainter` text is null (flutter/flutter#148462) 2024-05-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5500c1a3969a to fb64b9a4e6f2 (1 revision) (flutter/flutter#149307) 2024-05-30 tessertaha@gmail.com Enable `explicitChildNodes` for the `AlertDialog` content (flutter/flutter#149130) 2024-05-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c95e85dfbf4 to 5500c1a3969a (1 revision) (flutter/flutter#149304) 2024-05-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19707e811b60 to 0c95e85dfbf4 (1 revision) (flutter/flutter#149300) 2024-05-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) (flutter/flutter#149291) 2024-05-30 jonahwilliams@google.com disable Impeller on external texture test. (flutter/flutter#149292) 2024-05-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) (flutter/flutter#149290) 2024-05-30 kevinjchisholm@google.com Update 3.22.1 release notes to include missing fix. (flutter/flutter#148999) 2024-05-30 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) (flutter/flutter#149263) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Prevent LayoutBuilder from rebuilding more than once (#147856)" (flutter/flutter#149279) 2024-05-29 danny@tuppeny.com Unskip expression evaluation test (flutter/flutter#149253) 2024-05-29 yjbanov@google.com temporarily disable SemanticsAction tests to unblock engine change (flutter/flutter#149274) 2024-05-29 30870216+gaaclarke@users.noreply.github.com Adds benchmark for rrect_blur. (flutter/flutter#149261) 2024-05-29 31859944+LongCatIsLooong@users.noreply.github.com Prevent LayoutBuilder from rebuilding more than once (flutter/flutter#147856) 2024-05-29 32538273+ValentinVignal@users.noreply.github.com Add test for inherited_theme.0.dart (flutter/flutter#149120) 2024-05-29 73608287+ellet0@users.noreply.github.com Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS (flutter/flutter#145246) 2024-05-29 linxunfeng@yeah.net _ModalScopeStatus as InheritedModel (flutter/flutter#149022) 2024-05-29 32538273+ValentinVignal@users.noreply.github.com Add test for radio.toggleable.0.dart (flutter/flutter#149153) 2024-05-29 31859944+LongCatIsLooong@users.noreply.github.com Add a sentinel value for `TextStyle.height` (flutter/flutter#149049) 2024-05-29 katelovett@google.com Remove dynamic_layouts from issue template (flutter/flutter#149252) 2024-05-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) (flutter/flutter#149255) 2024-05-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) (flutter/flutter#149249) 2024-05-29 engine-flutter-autoroll@skia.org Roll Packages from a933c30 to 31d3329 (6 revisions) (flutter/flutter#149246) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fix slider text null error

9bcd556

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 16, 2024

goderbauer requested a review from TahaTesser May 17, 2024 21:06

TahaTesser requested changes May 20, 2024

View reviewed changes

packages/flutter/lib/src/material/slider_theme.dart Outdated Show resolved Hide resolved

hello-coder-xu added 3 commits May 21, 2024 10:39

Change implementation method

8a20781

fix slider text null error

5b7526b

Change implementation method

cf43def

TahaTesser force-pushed the fix/slider_text_null_error branch from 8a20781 to cf43def Compare May 21, 2024 12:54

hello-coder-xu added 3 commits May 22, 2024 09:28

fix warn

81c7ec7

remove launch.json

dccb4c9

TahaTesser requested changes May 22, 2024

View reviewed changes

packages/flutter/lib/src/material/slider.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/slider_theme_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/slider_theme_test.dart Outdated Show resolved Hide resolved

hello-coder-xu added 2 commits May 23, 2024 08:54

update suggested change

ca2c6c4

TahaTesser requested changes May 23, 2024

View reviewed changes

packages/flutter/test/material/slider_theme_test.dart Outdated Show resolved Hide resolved

hello-coder-xu added 2 commits May 24, 2024 09:30

move skip draw ValueIndicator test to slider_test.dart

2b3bd6e

Recover Format

a24f72e

TahaTesser requested changes May 24, 2024

View reviewed changes

packages/flutter/lib/src/material/slider_theme.dart Outdated Show resolved Hide resolved

Update packages/flutter/lib/src/material/slider_theme.dart

44b6937

TahaTesser changed the title ~~fix slider text null error~~ Fix Slider throws an error when _labelPainter text is null May 24, 2024

TahaTesser approved these changes May 24, 2024

View reviewed changes

TahaTesser requested a review from Piinks May 24, 2024 14:14

Piinks reviewed May 28, 2024

View reviewed changes

hello-coder-xu added 2 commits May 30, 2024 18:19

remove debugDisableShadows in test

61d0ec3

Piinks approved these changes May 30, 2024

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2024

auto-submit bot merged commit db5c143 into flutter:master May 30, 2024
72 checks passed

engine-flutter-autoroll mentioned this pull request May 30, 2024

Roll Flutter from c85fa6abf4ff to db5c1434e649 (24 revisions) flutter/packages#6834

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024

db5c1434e Fix Slider throws an error when _labelPainter text is n…

b48ccb5

…ull (flutter/flutter#148462)

engine-flutter-autoroll mentioned this pull request May 30, 2024

Roll Flutter from c85fa6abf4ff to 421c8c5ef59c (25 revisions) flutter/packages#6835

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024

db5c1434e Fix Slider throws an error when _labelPainter text is n…

7affc46

…ull (flutter/flutter#148462)

engine-flutter-autoroll mentioned this pull request May 30, 2024

Roll Flutter from c85fa6abf4ff to 7eebe2992aba (26 revisions) flutter/packages#6836

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024

db5c1434e Fix Slider throws an error when _labelPainter text is n…

df507ac

…ull (flutter/flutter#148462)

engine-flutter-autoroll mentioned this pull request May 30, 2024

Roll Flutter from c85fa6abf4ff to 3d4fd550c2b5 (29 revisions) flutter/packages#6837

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024

db5c1434e Fix Slider throws an error when _labelPainter text is n…

098832d

…ull (flutter/flutter#148462)

victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024

Fix Slider throws an error when _labelPainter text is null (flutt…

2390f02

…er#148462) *Fix flutter#148159*

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `Slider` throws an error when `_labelPainter` text is null #148462

Fix `Slider` throws an error when `_labelPainter` text is null #148462

hello-coder-xu commented May 16, 2024

hello-coder-xu commented May 23, 2024

TahaTesser left a comment

TahaTesser left a comment

Piinks May 28, 2024

hello-coder-xu May 29, 2024

TahaTesser May 29, 2024

Piinks May 29, 2024

hello-coder-xu May 30, 2024

Piinks left a comment

Fix Slider throws an error when _labelPainter text is null #148462

Fix Slider throws an error when _labelPainter text is null #148462

Conversation

hello-coder-xu commented May 16, 2024

Pre-launch Checklist

hello-coder-xu commented May 23, 2024

TahaTesser left a comment

Choose a reason for hiding this comment

TahaTesser left a comment

Choose a reason for hiding this comment

Piinks May 28, 2024

Choose a reason for hiding this comment

hello-coder-xu May 29, 2024

Choose a reason for hiding this comment

TahaTesser May 29, 2024

Choose a reason for hiding this comment

Piinks May 29, 2024

Choose a reason for hiding this comment

hello-coder-xu May 30, 2024

Choose a reason for hiding this comment

Piinks left a comment

Choose a reason for hiding this comment

Fix `Slider` throws an error when `_labelPainter` text is null #148462

Fix `Slider` throws an error when `_labelPainter` text is null #148462