fix(input): adjust colors, padding, fonts & heights for ionic theme #29520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
May 17, 2024
| } | ||
|
|
||
| :host(.label-floating) .label-text-wrapper { | ||
| @include transform(none); |
There was a problem hiding this comment.
By removing this transform we are able to set the font-size directly instead of scaling it down from the :host font size.
brandyscarney
commented
May 17, 2024
| * Label text should not extend | ||
| * beyond the bounds of the input. | ||
| */ | ||
| max-width: calc((100% - var(--padding-start) - var(--padding-end)) / #{$form-control-label-stacked-scale}); |
There was a problem hiding this comment.
This is no longer needed without the transform as a rule already exists to set the max-width here:
thetaPC
approved these changes
May 17, 2024
brandyscarney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Input styles were slightly different from the ionic theme design.
What is the new behavior?
Updates the following:
font-sizedirectlytokenswhere they were notDoes this introduce a breaking change?
Other information
The underline (undefined) fill looks off from the design but issue ROU-5151 exists for implementing it so I assume it will be fixed there.
Image Comparison
Note
The design is not going to match perfectly because we are not using the Inter font in our tests.