Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added multiple devices ability plus clkg with light accessory #326

Open
wants to merge 1 commit into
base: develop_1.7.0
Choose a base branch
from

Conversation

blvosh2
Copy link

@blvosh2 blvosh2 commented Jun 18, 2023

Hi, i am new to all of this, i am mainly AI python developer.
i have clkg curtain switch with light so i added the support, i would be happy for any further help.
Thanks !

@0x5e
Copy link
Owner

0x5e commented Jun 19, 2023

Thanks @blvosh2 for the contribution!
I understand the project doesn't support well with "combination products" like yours (window curtain + light), and there's "fan + light", "diffuser + light", "camera + switch" and more, we are not able to enumerate completely for all combinations.
I'm not ready for support multiple device ability currently, and the accessory classes may incompatible with each others because the "dp code" definition for same feature various to different products (what a mess :( )

For this PR, I propose to use a conservative way for now, like FanAccessory does. In WindowCoveringAccessory, when LIGHT_ON exists, then call configureLight to create a light accessory.

For multiple device support, I prefer configurable way (like https://github.com/arachnetech/homebridge-mqttthing/blob/master/docs/Configuration.md), let user mapping relations between homekit service/characteristic and tuya schema, I will complete it when I'm free. what do you think of it?

@blvosh2
Copy link
Author

blvosh2 commented Jun 19, 2023

I think its great !, i will start working on it at the weekend, thanks for your huge contribution with this plugin !, i will update as soon as i will complete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants