Use poll with nfds_t type #907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 16 makes -Wincompatible-function-pointer-types an error by default, which causes build failure for `(*_poll)` function because `nfds_t` does not need to be equivalent to `unsigned int`. This commit changes it in all poll function definitions and prototypes to `nfds_t` as it is defined by POSIX and defines `nfds_t` type as `unsigned int` when `WITH_POLL` is not defined. Fixes: 3proxy#895 See-also: https://bugs.gentoo.org/881015
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Mar 21, 2023
- EAPI bump - update HOMEPAGE and SRC_URI - update gentoo patch - add fix for clang-16 [1,2] - remove src_compile phase, CC is now exported in src_prepare, LN is not needed anymore as it is set to $(CC) by default. [1] 3proxy/3proxy#895 [2] 3proxy/3proxy#907 Closes: https://bugs.gentoo.org/881015 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 22, 2023
- EAPI bump - update HOMEPAGE and SRC_URI - update gentoo patch - add fix for clang-16 [1,2] - remove src_compile phase, CC is now exported in src_prepare, LN is not needed anymore as it is set to $(CC) by default. [1] 3proxy/3proxy#895 [2] 3proxy/3proxy#907 Closes: https://bugs.gentoo.org/881015 Signed-off-by: Petr Vaněk <arkamar@atlas.cz> Closes: #30287 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 16 makes -Wincompatible-function-pointer-types an error by default, which causes build failure for
(*_poll)function becausenfds_tdoes not need to be equivalent tounsigned int. This commit changes it in all poll function definitions and prototypes tonfds_tas it is defined by POSIX and definesnfds_ttype asunsigned intwhenWITH_POLLis not defined.Fixes: #895
See-also: https://bugs.gentoo.org/881015