Add a diagnostic dialog for missing variables #6573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D8H
commented
May 17, 2024
Comment on lines
+250
to
+253
| RaiseError(gd::ExpressionParserError::ErrorType::MissingBehavior, | ||
| _("This behavior is not attached to this object."), | ||
| function.behaviorNameLocation, | ||
| /*isFatal=*/false, function.behaviorName, function.objectName); |
There was a problem hiding this comment.
Here, we have the behavior name but not the expected type. It would be hard to build an understandable message so it's not forwarded to the report.
I think it's fine because behaviors instructions will likely be used too.
D8H
commented
May 20, 2024
| return gd::make_unique<ExpressionParserDiagnostic>(); | ||
| return std::unique_ptr<ExpressionParserError>(nullptr); |
There was a problem hiding this comment.
This change is not just a refactoring. It was wrongly replacing the null pointer with a default constructed instance.
When removing the base class with IsError() { return false }, it returned true which causes bugs.
IsError() no longer exists, only null is checked.
D8H
commented
May 20, 2024
4ian
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes