Skip to content

Commit

Permalink
chore: add ESLint-TS rules to enforce type imports and exports (#999)
Browse files Browse the repository at this point in the history
  • Loading branch information
ghiscoding committed Mar 19, 2024
1 parent 19432bd commit 89303ef
Show file tree
Hide file tree
Showing 11 changed files with 19 additions and 14 deletions.
5 changes: 5 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": ["./tsconfig.json"]
},
"settings": {
"node": {
"tryExtensions": [".js", ".json", ".node", ".ts", ".d.ts"],
Expand Down Expand Up @@ -36,6 +39,8 @@
"extendDefaults": true
}
],
"@typescript-eslint/consistent-type-exports": "error",
"@typescript-eslint/consistent-type-imports": "error",
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-non-null-assertion": "off",
Expand Down
2 changes: 1 addition & 1 deletion src/models/autoSize.interface.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Formatter } from './formatter.interface';
import type { Formatter } from './formatter.interface';

export interface AutoSize {
allowAddlPercent?: number;
Expand Down
4 changes: 2 additions & 2 deletions src/models/editorValidator.interface.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { EditorArguments } from './editorArguments.interface';
import { EditorValidationResult } from './editorValidationResult.interface';
import type { EditorArguments } from './editorArguments.interface';
import type { EditorValidationResult } from './editorValidationResult.interface';

export type EditorValidator = (value: any, args?: EditorArguments) => EditorValidationResult;
8 changes: 4 additions & 4 deletions src/models/grouping.interface.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Aggregator } from './aggregator.interface';
import { GroupingComparerItem } from './groupingComparerItem.interface';
import { GroupingFormatterItem } from './groupingFormatterItem.interface';
import { SortDirectionNumber } from './sortDirectionNumber.enum';
import type { Aggregator } from './aggregator.interface';
import type { GroupingComparerItem } from './groupingComparerItem.interface';
import type { GroupingFormatterItem } from './groupingFormatterItem.interface';
import type { SortDirectionNumber } from './sortDirectionNumber.enum';

export type GroupingGetterFunction<T = any> = (value: T) => any;

Expand Down
2 changes: 1 addition & 1 deletion src/models/interactions.interface.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// --
// slick.interactions.ts

import { DragPosition } from './drag.interface';
import type { DragPosition } from './drag.interface';

export interface InteractionBase {
destroy: () => void;
Expand Down
2 changes: 1 addition & 1 deletion src/models/slickPlugin.interface.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { SlickGridModel } from './slickGridModel.interface';
import type { SlickGridModel } from './slickGridModel.interface';

export interface SlickPlugin {
pluginName: string;
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/slick.cellcopymanager.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { CssStyleHash, SlickPlugin } from '../models/index';
import { keyCode as keyCode_, SlickEvent as SlickEvent_, type SlickEventData, Utils as Utils_, SlickRange } from '../slick.core';
import { keyCode as keyCode_, SlickEvent as SlickEvent_, type SlickEventData, Utils as Utils_, type SlickRange } from '../slick.core';
import type { SlickGrid } from '../slick.grid';

// for (iife) load Slick methods from global Slick object, or use imports for (esm)
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/slick.cellrangedecorator.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { CSSStyleDeclarationWritable, CellRangeDecoratorOption, SlickPlugin } from '../models/index';
import { Utils as Utils_, SlickRange } from '../slick.core';
import { Utils as Utils_, type SlickRange } from '../slick.core';
import type { SlickGrid } from '../slick.grid';

// for (iife) load Slick methods from global Slick object, or use imports for (esm)
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/slick.crossgridrowmovemanager.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { SlickEvent as SlickEvent_, SlickEventData as SlickEventData_, SlickEventHandler as SlickEventHandler_, Utils as Utils_ } from '../slick.core';
import { SlickEvent as SlickEvent_, type SlickEventData as SlickEventData_, SlickEventHandler as SlickEventHandler_, Utils as Utils_ } from '../slick.core';
import type { Column, DragRowMove, CrossGridRowMoveManagerOption, FormatterResultWithText, UsabilityOverrideFn } from '../models/index';
import type { SlickGrid } from '../slick.grid';

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/slick.rowmovemanager.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { SlickEvent as SlickEvent_, SlickEventData as SlickEventData_, SlickEventHandler as SlickEventHandler_, Utils as Utils_ } from '../slick.core';
import { SlickEvent as SlickEvent_, type SlickEventData as SlickEventData_, SlickEventHandler as SlickEventHandler_, Utils as Utils_ } from '../slick.core';
import type { Column, DragRowMove, FormatterResultWithHtml, RowMoveManagerOption, UsabilityOverrideFn } from '../models/index';
import type { SlickGrid } from '../slick.grid';

Expand Down
2 changes: 1 addition & 1 deletion src/slick.dataview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import {
SlickGroup as SlickGroup_,
SlickGroupTotals as SlickGroupTotals_,
Utils as Utils_,
SlickNonDataItem,
type SlickNonDataItem,
} from './slick.core';
import { SlickGroupItemMetadataProvider as SlickGroupItemMetadataProvider_ } from './slick.groupitemmetadataprovider';

Expand Down

0 comments on commit 89303ef

Please sign in to comment.