New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed all drag events to draggable handles #15
Conversation
Changed all drag events to draggable handles
Thanks! I wish all the pull requests were this concise and to the point. |
It looks like |
Give me a couple of minutes |
:-) |
Upon closer inspection this is somewhat less easy than expected. jquery.(drag|drop).event.js are actual events which propagate through the DOM (something which is used by the grid). Draggable/droppable from jquery UI doesn't. I will look into it a bit more, but the normal D'n'D behaviour will break with my previous pull request. |
From what I tell this isn't such a good idea to remove jquery.(drag|drop).event.js just yet, even though it is considered as legacy. To me it seems better if someone who knows more about the internals of SlickGrid takes a look at this. Stick with jquery.drag.event.js until then. |
There is possibly a way to put the external libraries into a different namespace so they don't clash with jQueryUI. I might investigate that approach. |
I've reverted the pull, actually deleted the history. I think I was quick enough that it won't affect anyone. Let's investigate some more. |
You may be interested to know there's a clone of the drag&drop lib used by SlickGrid in https://github.com/GerHobbelt/jquery.threedubmedia ; I know we have a few very subtle issues with it regarding touch (on modern touchscreen+mouse desktops / laptops) when the DOM gets complex enough, but it might be something to try if only to see if that one will float your boat. |
I'm interested, but I have to ask: why swap one additional dependency for another? I think we were hoping to find something built into jQuery or jQueryUI to do the job. |
Just more up to date, 's all. We're using it here in our main app with jQuery v2. |
After I tried to monkey patch jquery draggable into slickgrid it seemed to work pretty well. In case people have problems with jquery.event.drag.js (as I did), this will remove that dependency within the core grid.