PostgreSQL driver refactoring #1008
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dregad
commented
Nov 5, 2023
dregad
commented
- Fixes Refactor the PostgreSQL driver #955
- Fixes pgsql: metaTables() returns duplicated views #972
- Fixes pgsql: add support for metaTables() $showSchema parameter #973
- Fixes pgsql: incorrect parameter replacement in metaColumns() #974
Version-specific code has been merged into parent postgres64 class.
Version-specific code has been merged into parent postgres64 class. Notes: - Obsolete _bindInputArray property was removed - commented-out prepare() method was not carried over - ADORecordSet_assoc_postgres7 -> ADORecordSet_assoc_postgres64
This only contained a PHPDoc block, no code.
Following squashing of the postgresN drivers (with N being 64, 7, 8, 9) into the generic postgres one performed in previous commits, we now get rid of all references to the removed classes.
Simplify code by removing unnecessary assignments and duplicated code.
The information_schema's tables view already contains the views, so there is no need for an UNION query. The object's type (table/view) is stored in the table_type column. The metaTablesSQL query was modified accordingly. Fixes ADOdb#972
|
We noticed that ADORecordSet_postgres7->MoveNext() is setting: $this->fields = false; on the last row. This is causing us headaches because we are wanting to cache a recordset by serializing it (iterating over all rows), and iterate over it immediately after. But with $this->fields = false, that blocks us. Any ideas why this might be happening in this driver? I couldn't find it occurring in other MoveNext() calls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.