verify data size in deepscanlines which are not compressed #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
peterhillman
added a commit
to peterhillman/openexr
that referenced
this pull request
Jun 4, 2021
…eFoundation#1037) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Merged
cary-ilm
pushed a commit
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Jun 23, 2021
…eFoundation#1037) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
pushed a commit
that referenced
this pull request
Jun 30, 2021
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1033
If deep scanline data is not compressed, the input buffer size is read from file, and could be too small for the required data, causing a read buffer overrun when uncompressing data. When data is compressed, a sufficiently large buffer will always be allocated by the decompressor, so read bytes will always be valid.
Note: Other image types (regular images and deep tiles) may also have similar issues.
Signed-off-by: Peter Hillman peterh@wetafx.co.nz