New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Reload on #new #87
Comments
I'm in favor of changing this and targeting it at the 1.0 release. |
Following up on this; we are still calling I might propose rewriting L101-103 like so: if resource_uri
set_subject!(resource_uri)
reload
end Would this fit with the past (now closed) issues that reference this one? I haven't tested this change against the specs, just brainstorming. |
There is an open issue (#194) that is affected by reload. I do not know whether @mjsuhonos proposal would impact this for the better or worse. This issue came with the change from 0.6 to 0.8. |
So in using ActiveTriples::Resources as "Almost ActiveRecord" objects, the only big difference I found was that because they reload on #new, there's no such thing as a record with a URI in the database that's not persisted, which makes things like #new forms difficult.
We ended up writing https://github.com/OregonDigital/ControlledVocabularyManager/blob/feature/ActiveTermWrapper/lib/active_triples_adapter.rb
Should we push this kind of behavior into the AT API for a new major version?
The text was updated successfully, but these errors were encountered: