Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload on initialize. Fixes #87 #152

Open
wants to merge 1 commit into
base: v0.7.x
Choose a base branch
from
Open

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jun 18, 2015

This supersedes #114

@jcoyne
Copy link
Contributor Author

jcoyne commented Aug 12, 2015

This is kind of wonky when you attempt to interact with the resource directly.

if you do something like:

source.insert [subject, predicate, uri]
source.get_relation :foo

Because the insert doesn't mark loaded?, the get_relation ends up triggering a reload and the first insert is lost.

@mjsuhonos
Copy link
Member

Sorry, should've commented directly here. See respective comment on #87.

FWIW, I don't like the idea of having to manage persistence state (@persisting, @loaded, etc) within an RDFSource. IMO this is the job of a chosen PersistenceStrategy now that we have it.

@mjsuhonos
Copy link
Member

Also to clarify now that I've had a closer look, this is just for behaviour against v0.7.x, i.e. not to be carried forward into develop, correct?

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 26, 2016

Right, this is just 0.7.x

@mjsuhonos
Copy link
Member

Right, sorry. Never mind me, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants