Contacts/README.textile FSEventsWrapper/.gitignore @@ -512,7 +512,7 @@ static CFRunLoopSourceRef RunloopSourceForStream( NSStream * stream, mach_port_t [_delegate stream: self handleEvent: event]; } -- (NSInteger) write: (uint8_t *) buffer maxLength: (NSUInteger) len +- (NSInteger) write: (uint8_t const *) buffer maxLength: (NSUInteger) len { if ( _status != NSStreamStatusOpen ) return ( 0 ); Compression/AQGzipFileStream.m @@ -316,9 +316,11 @@ return ( [_compressedDataStream propertyForKey: key] ); } -- (void) setProperty: (id) property forKey: (NSString *) key +- (BOOL) setProperty: (id) property forKey: (NSString *) key { - [_compressedDataStream setProperty: property forKey: key]; + if ( [_compressedDataStream setProperty: property forKey: key] == NO ) + return ( [super setProperty: property forKey: key] ); + return ( YES ); } @end Compression/AQGzipInputStream.m @@ -297,9 +297,11 @@ return ( [_outputStream propertyForKey: key] ); } -- (void) setProperty: (id) property forKey: (NSString *) key +- (BOOL) setProperty: (id) property forKey: (NSString *) key { - [_outputStream setProperty: property forKey: key]; + if ( [_outputStream setProperty: property forKey: key] == NO ) + return ( [super setProperty: property forKey: key] ); + return ( YES ); } @end Compression/AQGzipOutputStream.m @@ -142,7 +142,10 @@ } } - return ( [NSError errorWithDomain: domain code: code userInfo: userInfo] ); + NSError * result = [NSError errorWithDomain: domain code: code userInfo: userInfo]; + [userInfo release]; + + return ( result ); } @end Extensions/NSError+CFStreamError.m @@ -217,7 +217,7 @@ enum - (BOOL) setupFSEventListener { - int clonefd; + int clonefd = -1; struct fsevent_clone_args clone_args; int8_t event_list[] = { FSE_REPORT, // create file @@ -342,6 +342,8 @@ enum FSEvent * event = [[FSEvent alloc] init]; event.eventCode = pEvt->type & FSE_TYPE_MASK; event.processID = pEvt->pid; + + BOOL isVnode = NO; // read arguments kfs_event_arg_t *pArg = pEvt->args; @@ -356,7 +358,6 @@ enum int argOffset = sizeof(pArg->type) + sizeof(pArg->len) + pArg->len; offset += argOffset; - BOOL isVnode = NO; int argType = (pArg->type > FSE_MAX_ARGS) ? 0 : pArg->type; switch ( argType ) LowLevelFSEvents/FSEventManager.m @@ -132,11 +132,6 @@ static AQConnectionMultiplexer * __connectionMultiplexer = nil; [self autorelease]; } -- (void) _terminate -{ - [self _cancelTransfers]; -} - - (void) _addHelper: (AQLowMemoryDownloadHelper *) helper { @synchronized(_downloadHelpers) @@ -164,6 +159,11 @@ static AQConnectionMultiplexer * __connectionMultiplexer = nil; } } +- (void) _terminate +{ + [self _cancelTransfers]; +} + - (void) main { NSAutoreleasePool * rootPool = [[NSAutoreleasePool alloc] init]; LowMemoryDownload/AQConnectionMultiplexer.m @@ -124,6 +124,7 @@ didReceiveAuthenticationChallenge: (NSURLAuthenticationChallenge *) challenge; obj.asyncDelegate = delegate; [obj _performAsynchronousRequest: request]; + [obj release]; } - (id) init LowMemoryDownload/AQLowMemoryDownloadHelper.m @@ -919,10 +919,6 @@ static void __ignorableWhitespace( void * ctx, const xmlChar * ch, int len ) if ( _stream == nil ) return ( NO ); - xmlSAXHandlerPtr saxHandler = NULL; - if ( self.delegate != nil ) - saxHandler = _internal->saxHandler; - // see if bytes are already available on the stream // if there are, we'll grab the first 4 bytes and use those to compute the encoding // otherwise, we'll just go with no initial data @@ -1242,11 +1238,10 @@ static void __ignorableWhitespace( void * ctx, const xmlChar * ch, int len ) return; } - CFNumberRef num = (CFNumberRef) [_stream propertyForKey: (NSString *)kCFStreamPropertyFTPResourceSize]; + NSNumber * num = [_stream propertyForKey: (NSString *)kCFStreamPropertyFTPResourceSize]; if ( num != NULL ) { - _internal->expectedDataLength = [(NSNumber *)num floatValue]; - CFRelease( num ); + _internal->expectedDataLength = [num floatValue]; return; } StreamingXMLParser/AQXMLParser.m 3c962940928de3758e74cb3d230c37222bceae7f Jim Dovey jimdovey@mac.com http://github.com/AlanQuatermain/aqtoolkit/commit/ad27dbfe6d50f448ba5bdfd93a6d840d60c1ca0e ad27dbfe6d50f448ba5bdfd93a6d840d60c1ca0e 2009-07-01T19:34:57-07:00 2009-07-01T19:34:57-07:00 Fixes for bugs found by the Clang static analyzer. 8dbeccec6e16b1261ce1bb052d3e75fcd0a1d7c5 Jim Dovey jimdovey@mac.com