Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for pytorch_lightning >= 1.0.0 #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix for pytorch_lightning >= 1.0.0 #21

wants to merge 2 commits into from
+8 −9

Conversation

GPla
Copy link

@GPla GPla commented Dec 28, 2020

No description provided.

@lucasfijen
Copy link

Nice pullrequest, following on your changes, I found that also default_save_path should be changed into default_root_dir for the Trainer in run.py to work with lightning 1.2.0

@lukesalamone
Copy link

Shouldn't this also change requirements.txt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GPla @lucasfijen @lukesalamone