Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!] GENERAL discussion, feedback, questions belong here! (v7) #189

Closed
Aris-t2 opened this issue Feb 12, 2019 · 259 comments
Closed

[!] GENERAL discussion, feedback, questions belong here! (v7) #189

Aris-t2 opened this issue Feb 12, 2019 · 259 comments

Comments

@Aris-t2
Copy link
Owner

Aris-t2 commented Feb 12, 2019

Make sure you updated to the most recent version of this projects files "before" reporting problems!

Continued from #3, #41, #88, #109, #133 and #163.

Instead of opening new "issues" for general talk we can use this area for discussions, feedback and questions. Open new "issues" for real bugs and problems.

Custom JS scripts to restore more classic features
https://github.com/Aris-t2/CustomJSforFx

Trying to make CSS code ready for Firefox Quantum (57+)?
Remove all @namespace references. They are the reason, if your code refuses to work.

Application/hamburger button in tabs toolbar?
Look here: #46

Things this project will not target/recreate

  • curved tabs
  • old complete themes
  • ...

Things not possible with CSS

  • more toolbars like add-on/status bar (CSS can not create new toolbars)
    • displaying full sized status popup below window content is possible
    • moving bookmarks toolbar to windows bottom is possible
  • new buttons (CSS can not create new buttons)
  • additional menuitems (CSS can not create new items)
  • custom/new/different functions for buttons/menuitems/menus
  • activity indicator
  • preference/options window
  • additional location bar
  • favicon in location bars identity box
  • moving menubar items to a different toolbar
  • restart button
  • ... many more
@ghost
Copy link

ghost commented Feb 12, 2019

@Aris-t2

hi. followup to comments at #163 ...

I've not added any of 'my own code' for chrome ... at least not knowingly.

With my_userChrome.css containing, now,

#navigator-toolbox > toolbar:not(#toolbar-menubar):not(#TabsToolbar):not(#nav-bar) {
  padding-left: 0px !important;
  padding-right: 0px !important;
}

#navigator-toolbox > #PersonalToolbar {
  min-height: 30px !important;
  padding-top: 2px !important;
  padding-bottom: 2px !important;
}

#main-window #navigator-toolbox #TabsToolbar .tabs-newtab-button,
#main-window #navigator-toolbox #TabsToolbar #new-tab-button {
  margin-left: 20px !important;
  margin-right: 20px !important;
}

I (still) have:

screenshot_20190212_103829

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 12, 2019

Add the code to the bottom of your userChrome.css, just to be sure.
You could also test a new browser profile. On your screenshot I see no code changes at all neither bookmarks toolbar nor tabs toolbar.

@ghost
Copy link

ghost commented Feb 12, 2019

@Aris-t2

adding that^ same code to userChrome.css does the trick -- or, at least, has a noticeable change:

screenshot_20190212_111309

checking ... oh %$%! I just noticed

/* @import "./my_userChrome.css"; /**/

in userChrome. I'd completely missed the fact (reading only about it in online posts) that that needs to be UNcommented.

Doing that, and rm'ing the code from userChrome.css, now ... the change does appear.

(1) PEBKAC!
(2) duh ...
(3) sry for the confusion !!

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 13, 2019

Try to increase bookmark toolbars padding more than in the above code:

#navigator-toolbox #PersonalToolbar {
  min-height: 30px !important;
  padding-top: 10px !important;
  padding-bottom: 10px !important;
}

Are your bookmarks on bookmarks toolbar or on another toolbar?

@ghost
Copy link

ghost commented Feb 14, 2019

Try to increase bookmark toolbars padding more than in the above code:

That works as expected,
screenshot_20190213_162505

Are your bookmarks on bookmarks toolbar or on another toolbar?

Yes, my displayed-in-browser bookmarks -- above the TABs, below the NAV -- are on the "Bookmarks Toolbar"

@nollinvoyd
Copy link

When I upgrade CustomCSSforFx, I keep my previous version, and update it by incorporating the changes I find in the latest usercharome.css and usercoontent.css at https://github.com/Aris-t2/CustomCSSforFx/releases, which i also compare with the latest release version.

But over the course, and especially lately, I find that the changes on the release page don't always match the latest CustomCSSforFx userchrome/css and usercontenet.css release.

Which source should take precedence, the release page or the latest version?

@nollinvoyd
Copy link

nollinvoyd commented Feb 15, 2019

@Aris-t2

By complete package I mean the full release of this projects files: Aris-t2/CustomCSSforFx/releases

Backup your /chrome/ folder, extract all files from releases zip file into a new empty /chrome/ folder.
Change tab height in general_variables.css ( /classic/config/general_variables.css@master#L9 ).

I removed all the custom code for tab height in userchrome.css you gave me in the past and then altered general_variables.css

/* general settings */ :root { /* custom height for 'classic squared tabs' only */ --classic_squared_tabs_tab_height: 21px !important;

That worked. Thanks

@bendover22
Copy link

bendover22 commented Feb 16, 2019

What happened to thread #163? Too long?
I added only tabs multiple lines v2 @import in my own userChrome; and added the custom "CSS" folder & files to my profiles /chrome folder. It works, and all the tabs styling I previously did in userChrome - still worked. Except the vertical lines / separators between adjacent tabs.

I don't see anything in your tabs_multiple_lines_v2.css that would remove the tab separators, unless it's the code below - "border-left: unset." They weren't too obvious, but I need some of that "crap!". :)

/* remove **_crap_** set by Firefox 58+ */ .tabbrowser-tab::after, .tabbrowser-tab::before { border-left: unset !important; border-image: unset !important; border-image-slice: unset !important; border: 0 !important; }

Without searching the custom Linux Cinnamon theme I use - which styles almost EVERY possible thing in Mint & all apps, the theme probably just changed the color of what they call "border-left" on the tabs. So if only a left border is applied to each tab & if it's 1px, the separator is only 1px wide.

The config/general_variables.css has --classic_squared_tabs_tab_height: 26px,
but tabs_multiple_lines_v2.css has 32px for max height. Why such a difference?
I'm undecided on the easiest way to keep up with where I'm making changes to your custom code.
Making changes in the userChrome & others in one of many files in the config folder could get confusing.

You might want to add to the comment(s) in custom code - what is being removed from the Fx native theme when that's the case,
Thanks!

@bendover22
Copy link

I don't see right off how to override the 32px tab height. There are many other times that tab height is mentioned in the tabs_multiple_lines_v2.css, like:
#tabbrowser-tabs, #tabbrowser-tabs > .tabbrowser-arrowscrollbox { min-height: var(--tab-min-height_mlt)
I'm not familiar w/ "mlt."

Changing the first instance of that, from 32px to 28,
--tab-min-height_mlt: var(--tab-min-height,28px);
where you comment, "set your own value here if used w/o configuration files," didn't reset the tabs' height to the original 28 - if it was supposed to do that.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 16, 2019

@bendover22
Yes the previous thread was too long. (you can see "v7" indicates this is the seventh general support thread alraeay ;)).

A lot of CSS code used in this projects files change or remove stuff, it would not be possible to protocolize specific changes inside userChrome.css.

You are right about the code you pointed out. It hides tab separators, so remove it to restore the default ones the browser sets.

The value 32px in tabs_multiple_lines_v2.css is only a fallback value, the real one is set inside the variable --tab-min-height_mlt, which itself gets the value from --tab-min-height (a default browser variable). The later one gets override by a value in classic_squared_tabs.css, if this one is active.

If you are using default browser tabs, you have to override the variable --tab-min-height manually or replace --tab-min-height_mlt: var(--tab-min-height,32px); with --tab-min-height_mlt: 30px !important;.

It looks a bit complex, but that is how this project simulates an add-on.

Edit

Try to override that files variable in root area like this: --tab-min-height_mlt: 30px !important;

@bendover22
Copy link

bendover22 commented Feb 17, 2019

Thanks Aris. Umm... there is no "--tab-min-height" (all tab height declarations have the "_mlt" at the end), other than: --tab-min-height_mlt: var(--tab-min-height,32px);.
At least, it's not in aris-custom_css_for_fx_v2.3.6 / 2.4.2 - "tabs_multiple_lines_v2.css."
I'll try the last line you showed, but I think the problem may be due to the vertical scrollbar for multi tab rows. It's longer than the tabs' content box. You'll have to read - I can't upload screens? Not allowed?

1st question: using "tabs_multiple_lines_v2.css," are the tabs supposed to be below the title bar (if title bar is shown) & against the nav bar's top edge? That's how it displays for me.

All the files included in your "css" folder in the zip pkg are in the folder - inside my /chrome folder, but
@import "./css/tabs/tabs_multiple_lines_v2.css";
is the only @import line I added to the top of my userChrome.css..
I didn't use your userChrome.css.

I also compared the original multiple_lines file against the one in my /chrome/css folder. They're identical except for changing the 32px to 28, and commenting out the section that removes borders.
I could add the line you mention - if you give me the full code, but we've got other problems.
Maybe you're thinking another file that line is in? Or did you mean from line 17?:
--tab-min-height_mlt: var(--**tab-min-height**,32px);
Changing height there doesn't fix the problem that I'm seeing. It's not really the "tab" height that's the problem. Read on.

Looking further, it may have to do w/ the multi-row scrollbar. When I enter Fx's customize mode, it shows where the scrollbar would be (even when only 1 tab row, when the scrollbar is hidden). In customize mode, the bottom of the scrollbar channel is below the (normal) bottom of tabs, w/ just 1 row.

I'm not sure why it's adding an extra 19px high blank area, below the tabs, but that's the issue. The scrollbar's min length / height (hidden when only 1 row of tabs) may be causing it to add an additional blank space - BELOW the tab content box. I can't upload screen shots - not allowed?

I'm fairly certain I'm using the native tabs (size, shape). Only color styling; where favicons are placed (closer to L end); removing fading of tab content; hiding tab close button until hovered.
NONE of that is affecting the problem of it adding a blank space below each tab content box.
(No, the "classic_squared_tabs.css isn't active - so far).

What I see w/ tabs_multiple_lines_v2.css in .mozilla/firefox/{profile-name}/chrome/css/ is the actual tab content box w/ the borders is 33px h. That's including a top border of a 2px & a 1px, top-only border = 3px. I'm fairly sure the 3px top border for the selected tab is default value (switching to the themes incl. w/ the distro - Mint 18.1).

All themes have same behavior & the new problem w/ multi rows. The Linux themes & my custom theme all gave the same size tabs (as before trying multi tab rows).
_Below the tabs is where the problem is, as soon as I added the CSS folder in /chrome & added the line in my userChrome.css to import "tabs_multiple_lines_v2.css."

I was part right y'day. The "tabs" content box itself is 33 px (incl. the 3px top border).
As said, I changed the line: --tab-min-height_mlt: var(--tab-min-height,28px). As you said, that doesn't strictly set the height.
Then apparently, the code in tabs_multiple_lines_v2.css caused it to add another 19 px H "blank space" below the tab content box, on EACH of 3 rows. Overall, that makes each tab row 54px H.

@bendover22
Copy link

Yes, it appears the scrollbar for tab rows was causing the 19px high blank space under tabs;
whether there was 1, 2 or 3 tab rows.

I commented out every declaration that mentioned "scrollbox" & the 19px blank space went away.
Unfortunately, so did multi row tabs. I figured it would, I wanted a quick way to see if the tab rows scrollbox was causing the 19px high blank area under tabs. It apparently was - or something else in the declarations that also mentioned scrollbox.

FYI, w/o the custom css > multi tab rows code for a scrollbox being active, my UNselected tabs are 33px H (content box + a 1px border- bottom of unselected tabs). I'll have to DOUBLE check that tomorrow.
Selected tab is same overall, but has a 2px bottom border, so the selected tab content box "shrinks" to stay the same 33px ht as unselected tabs.

In the "tabs_multiple_lines_v2.css" code, it's a possibility the bottom of the new tab button is below the bottom of (my) tabs.
In customize mode, the selected tab's 33px H (will re-check); the bottom of new tab button is 41px (from the top of selected tab) - that may be one problem. Unless they shift when in customize mode.
In same customize mode, the scrollbox ht = selected tab = 35px. two px taller than tabs. I don't know if their positions in customize mode proves anything.

In "tabs_multiple_lines_v2.css" , I don't know how to shrink the scrollbox & arrows, etc, so they're not longer or lower than the tabs are high. Not w/o screwing up their function. Is it possible to scroll tab rows w/ a mouse - same as a web page & ditch the scrollbar?

I know how to set sizes, margins, padding, etc. I don't know all the options (& syntax) that can be used w/ scrollboxes on the tabs bar.

@LionWrathz
Copy link

LionWrathz commented Feb 17, 2019

how can i change the context-navigation,#context-forward color to red and #context-back,menuitem, to blue i tried changed it but it didn't work.

https://i.imgur.com/7X2P5qa.gifv

##context-navigation menuitem[disabled=true],
#context-forward,menuitem,
menu[disabled=true],
menuitem[disabled=true] {
color: red !important
}

#context-navigation menuitem[disabled=true],
#context-back,menuitem,
menu[disabled=true],
menuitem[disabled=true] {
color: blue !important
}

#context-navigation menuitem[disabled=true],
menu[disabled=true],
menuitem[disabled=true] {
color: blue !important
}

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 17, 2019

@bendover22
Your posts are too long to read. ;-)
Post a screenshot of your problem.

There is code in https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/css/tabs/tabs_multiple_lines_v2.css#L57 to prevent a horizontal scrollbar, but you might want to try this one:

#TabsToolbar,
#tabbrowser-tabs,
#tabbrowser-tabs * {
  overflow-x: hidden !important;
}

Keep in mind there is a "multirow tabs" support thread present here: #39

@LionWrathz
Look here to see how to change icon colors of these context menu icons:
https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/css/generalui/context_bfrsb_icons_colorized.css

@That-Random-Guy
Copy link

Is it possible to figure out the source image of a particular extension icon? For example, I've gotten used to keeping the StumbleUpon StumbleBar icon next to the home button in the navbar. I'm not asking for this to be implemented in official code or to add this functionality, I'm simply asking if it's possible to find such a thing and later add it in manually via JavaScript. The reason being, the mentioned extension isn't being maintained anymore and has been removed from Mozilla's add-on site. I still have it installed but I will be removing it shortly.
stumblebar_icon

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 17, 2019

You could either find the image using developer tools like mentioned on main page or you could unpack the add-on, which is still in your profiles folder somewhere,
about:support > add-ons/extensions > name
Search for the id of it within profile folder.

@bendover22
Copy link

Aris, if you can implement any of these suggestions, I hope (pretty sure) they'd save you time in the long run.
The support threads / discussions are on the "issues" page, not " Official Discussion Threads Main Page." :) Just sayin'. It's great to have them! Click the ! icons beside the threads (I did). It says "open issue." Today, it also says: "18 Open Issues." Just pointing out - this is a very unusual way to list official discussion threads / forums mixed among real bugs reports.

It never dawned on me & surely others, to read all "issues" titles on that page.
Maybe put a button or link w/ large text at top of Issues page: "LIST OF ALL DISCUSSION THREADS," w/ drop menu & links to all discussion threads. A little work, but easiest to get users to correct place.
There's a "Labels" button - most wouldn't assume that's to sort issues by: "Discussions."
You could add note explaining it. Most new users won't know what "Labels" is for unless they use Github a lot (I don't).

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 17, 2019

Well, its Github not a forum, so there is no such thing as "Official Discussion Threads Main Page" and of course there are no forum features for issue threads. ;-).

It never dawned on me & surely others, to read all "issues" titles on that page.

Because of that the main threads are mentioned within userChrome.css and in the issue template.

@Pizzapops
Copy link

Latest Nightly introduced a redesign of add-ons manager. To view it, load about:config and search for extensions.htmlaboutaddons.enable . Toggle preference to TRUE and load about:addons.
Typical Mozilla design: takes way too much screen real estate and adds more mouse clicks. My Aris enhanced Add-ons Manager shows all active add-ons on one page and inactive add-ons on a following half page. The new design is six pages. If only someone would do an AiOS style. Sidebar Add-ons Manager.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 19, 2019

I've seen this new change. Here is the code to break the new nonsense ;-)

@namespace html "http://www.w3.org/1999/xhtml";
@namespace xul "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";

body > div#main {
  margin-inline-start: 0px !important;
  margin-inline-end: 0px !important;
  margin-bottom: 4px !important;
  max-width: unset !important;
  background: linear-gradient(to bottom right, #f5f5f5,-moz-Dialog,#f5f5f5,-moz-Dialog) !important;
}

body > div#main > div.list-section .addon.card {
  margin-bottom: 4px !important;
}

body > div#main > div.list-section .addon.card:hover {
  background: Highlight !important;
  color: HighlightText !important;
}

body > div#main > div.list-section .addon.card:hover span {
  color: HighlightText !important;
}

body > div#main > div.list-section[type="disabled"] {
  opacity: 0.8 !important;
}

@bendover22
Copy link

Edit: now I see why couldn't upload images in posts. Only when you click the "attach files" bar below, another script tries to load that needs permission, or else image uploads fail w/o meaningful error message.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 20, 2019

@bendover22
You can just drag & drop images into your post above, between or right after the text you typed.

@JonnyThree
Copy link

Hello i find those pages really useful, but sadly i can't find a solution to the new Firefox 65 changes. I use from a lot a time a personal css to make tabs thinnier, but now i have a bug: when i open a lot of tabs, and the arrowsrollbox appear, the newtab button changes automatically appeareance and it becomes awful. Can someone suggest me a fix for this new Mozilla insanity?
This is my code:

#TabsToolbar > toolbarpaletteitem, #TabsToolbar > toolbarbutton {margin: unset !important;}
#tabbrowser-tabs,
#tabbrowser-tabs > .tabbrowser-arrowscrollbox,
.tabbrowser-tabs[positionpinnedtabs] > .tabbrowser-tab[pinned] {min-height: 22px !important; max-height: 22px !important;}
#TabsToolbar .tabs-newtab-button .toolbarbutton-icon {width: 18px !important; height: 18px !important; padding: 2px !important;}
#navigator-toolbox[movingtab] > #titlebar > #TabsToolbar {padding-bottom: unset !important;}
#navigator-toolbox[movingtab] #tabbrowser-tabs {padding-bottom: unset !important; margin-bottom: unset !important;}
#navigator-toolbox[movingtab] > #nav-bar {margin-top: unset !important;}
.tab-content {padding: 0px 3px 0px 3px !important; font-family: PT Sans !important; font-size: 13px !important;}
.tab-close-button {color: red !important;}
.tabs-alltabs-button {display: none !important;}
.tabbrowser-tab:not([pinned]) {min-width: 50px !important;}

@Achille-Grs
Copy link

Achille-Grs commented Feb 20, 2019

Hello again @Aris-t2
I maked some changes in the code for bookmarks multiple lines for Firefox 66.
First, use the file "bookmarks multiple lines" from Firefox 65 and just add in the top the extra code:


#PersonalToolbar {
min-height: var(--bookmark_items_height) !important;
max-height: calc(var(--bookmark_items_height)*(var(--bookmark_items_lines))) !important;
}  
#PlacesToolbar,
#PlacesToolbarItems {
overflow: visible;
display: block;
}
#PlacesToolbarItems > .scrollbox-innerbox {
display: flex;
flex-wrap: wrap; 
overflow-x: hidden !important;
overflow-y: visible !important;
max-height: calc(var(--bookmark_items_height)*(var(--bookmark_items_lines))) !important
}

Now, the code working perfect without limit for multiple lines, like firefox 65.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 21, 2019

@JonnyThree

Try this code or create a mod based on it:

.tabs-newtab-button .toolbarbutton-icon {
  min-width: 0px !important;
  min-height: 0px !important;
  width: 14px !important;
  height: 14px !important;
  margin: 0px !important;
  margin-bottom: 0px !important;
  padding: 0px !important;
}

@Achille-Grs
Thanks for the code.

@Speravir
Copy link

For next update: typo serachbar.

@WhiteDragonD
Copy link

Can you help me with the multi row tabs overlapping the personal (bookmark) toolbar?

Firefox 65.0.1, CustomCSS v2.4.3.

@import "./css/tabs/classic_squared_tabs.css";
@import "./css/tabs/tabs_below_navigation_toolbar_fx65.css";
@import "./css/tabs/tabs_multiple_lines_v2.css";

When I shrink my browser width, the tabs overlap the bookmark bar.

Firefox 64.0.2
headertabssetuplocationlooks

Firefox 65.0.1 before shrinking width
headerff65-issue1a

Firefox 65.0.1 after shrinking width
headerff65-issue1b

@Aris-t2
Copy link
Owner Author

Aris-t2 commented May 31, 2019

@rebop

  • Customizing mode > "Reset to default"
  • start with a clean setup of this projects files
  • change settings like mentioned earlier

@rebop
Copy link

rebop commented May 31, 2019

OK. Started clean with 2.54

Back and forward very good with a small exception. If no history, looks like this:

image

As soon as there is history and I return, looks as expected:

image

Thanks!

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 1, 2019

Well you have a very weird toolbar setup. Why would you place your back and forward buttons between location bar and search bar?

The option custom_backforward_connected_to_location_bar.css is for the case where the buttons are placed before location bar (default position) to simulate the "old" behavior.
1


Edit

Instead of custom_backforward_connected_to_location_bar.css test this code (normal mode only):

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button:not([disabled="true"])::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button[disabled="true"]::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"],
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button {
  opacity: 1.0 !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button .toolbarbutton-icon {
  opacity: 1.0 !important;
  background: #f9f9fa !important; 
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button:not([disabled="true"])::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button[disabled="true"]::before {
  display: block !important;
  content: "" !important;
  width: 32px !important;
  height: 32px !important;
  -moz-margin-start: -31px !important;
  -moz-margin-end: -9px !important;
  border-radius: 10000px !important;
  background: #f9f9fa !important; /*  #ddebf9*/
  position: relative !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button .toolbarbutton-icon {
  width: 38px !important;
  height: 30px !important;
  padding-top: 6px !important;
  padding-bottom: 6px !important;
  -moz-padding-start: 12px !important;
}

Edit 2
Fixed back button color for non-default themes.

@rebop
Copy link

rebop commented Jun 1, 2019

Hah! Been like that since well before I ever used Firefox Ver 1 or 3 - wherever I started that route. Convenient for me. Less mouse travel than to the left end of the bar.

I'll try this code and let you know.

Thanks.

~Bob

@rebop
Copy link

rebop commented Jun 1, 2019

REALLY close. Paints the background on the Back button and portion of the toolbar. Other than that, perfect.

Had no idea I was such an outlier on this one.

image

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 1, 2019

I updated the code.

@rebop
Copy link

rebop commented Jun 1, 2019

Almost:

image

And thanks for all this Aris. I will have to find a way to repay on this project. I will have that last tough one after this one done.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 1, 2019

Add this code too (Most of the glitches are caused by your theme, which causes button transparency look fishy. Code worked right away with the default one ;-)):

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button .toolbarbutton-icon {
  opacity: 1.0 !important;
  background: #f9f9fa !important; 
}

@rebop
Copy link

rebop commented Jun 1, 2019

That makes them both white buttons:

image

Getting close to gone for the day. Will look further tomorrow. Thanks for helping.

Just for comparison, here is the 56 version:
image

@rebop
Copy link

rebop commented Jun 1, 2019

We are obviously much close than we started.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 1, 2019

It won't get any closer. Transparency requires those buttons to use solid colors. Otherwise you will see one button behind the other.

@Speravir
Copy link

Speravir commented Jun 1, 2019

Release notes for v. 2.5.5:

(fix) Fx67+: add-on lists > show add-on version number > display private indicator (when corresponding switch is set)

Good solution! But what a switch? The style made active?

fixed a typo

Though it’s not that important: Maybe, but not the little one I have pointed to.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 2, 2019

@Speravir

Good solution! But what a switch? The style made active?

1

@krystian3w
Copy link
Contributor

krystian3w commented Jun 2, 2019

Purple ".privateBrowsing-notice" is no needed "#6200a4".

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 2, 2019

It gets overridden anyway.

@rebop
Copy link

rebop commented Jun 2, 2019

It won't get any closer. Transparency requires those buttons to use solid colors. Otherwise you will see one button behind the other.

OK. I colored them which I think looks a bit better, but realize these are always in the active state and do not change based on whether there are back or forward pages to go to. Can we fix that? This is with no forward or back pages active:

image

And I think would be nice, but not at all a requirement, for the toolbar buttons to be colorized and yet keep this gray scale.

Once i can get this one put to bed will post the final one or two. Thanks!

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 3, 2019

/* disabled state */
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar :-moz-any(#back-buton,#forward-button)[disabled="true"] .toolbarbutton-icon {
  background: grey !important; 
}

/* hover state */
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar :-moz-any(#back-buton,#forward-button):not([disabled="true"]):hover .toolbarbutton-icon {
  background: blue !important; 
}

/* active state */
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar :-moz-any(#back-buton,#forward-button):not([disabled="true"]):active .toolbarbutton-icon {
  background: green !important; 
}

@rebop
Copy link

rebop commented Jun 3, 2019

Thanks. I tried placing that in my_userChrome.css with the other code an no change.

I tweaked the code a little, though the states were not changing before my tweaks. Code now is:

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button:not([disabled="true"])::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button[disabled="true"]::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"],
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button {
  opacity: 1.0 !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button .toolbarbutton-icon {
  opacity: 1.0 !important;
  background: #E0E0E0 !important; 
  box-shadow: 2px 2px 2px  #888888!important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button:not([disabled="true"])::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button[disabled="true"]::before {
  display: block !important;
  content: "" !important;
  width: 32px !important;
  height: 32px !important;
  -moz-margin-start: -31px !important;
  -moz-margin-end: -9px !important;
  border-radius: 10000px !important;
  background: #f9f9fa !important; /*  #ddebf9*/
  position: relative !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button .toolbarbutton-icon {
  width: 35px !important;
  height: 27px !important;
  padding-top: 6px !important;
  padding-bottom: 6px !important;
  -moz-padding-start: 12px !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button .toolbarbutton-icon {
  opacity: 1.0 !important;
  background: #E0E0E0 !important; 
} 

Looks like this now at all times.

image

56, of course looks like this:

image

Thanks again.

@Pizzapops
Copy link

More fiddling with about:addons, Themes.
The theme display that is more like A.M.O used to be and utilizes screen real estate. Grid can be set to 3 or 4 columns. I still have to fix display conflicts with other categories and details. I also want to move category selection container from left side to top.
2019-06-03_133113
2019-06-03_132924
@Aris-t2 is it time for v8?

@rebop
Copy link

rebop commented Jun 5, 2019

Thanks. I tried placing that in my_userChrome.css with the other code an no change.

I tweaked the code a little, though the states were not changing before my tweaks. Code now is:

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button:not([disabled="true"])::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button[disabled="true"]::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"],
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button {
  opacity: 1.0 !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button .toolbarbutton-icon {
  opacity: 1.0 !important;
  background: #E0E0E0 !important; 
  box-shadow: 2px 2px 2px  #888888!important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button:not([disabled="true"])::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button[disabled="true"]::before {
  display: block !important;
  content: "" !important;
  width: 32px !important;
  height: 32px !important;
  -moz-margin-start: -31px !important;
  -moz-margin-end: -9px !important;
  border-radius: 10000px !important;
  background: #f9f9fa !important; /*  #ddebf9*/
  position: relative !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button .toolbarbutton-icon {
  width: 35px !important;
  height: 27px !important;
  padding-top: 6px !important;
  padding-bottom: 6px !important;
  -moz-padding-start: 12px !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button .toolbarbutton-icon {
  opacity: 1.0 !important;
  background: #E0E0E0 !important; 
} 

Looks like this now at all times.

image

56, of course looks like this:

image

Thanks again.

@Aris-t2

You might have missed this, but trying your code above to change states did not work for me as mentioned above. Can we get these buttons to show active or dormant?

And that brings me to my last issue :)

I have played a lot with location bar settings but cannot get close to what I have in 56 for the dropdown in 68. Here is what I see:

56 (blurred for privacy but shows two lines, data, nice layout):

image

68 (not so nice. but best I could achieve):

image

If I try for two lines of data they overlap.

Would love to solve these two. Thanks again.

~Bob

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 6, 2019

@rebop
I wrote this code directly into this thread and assumed it would work right away. Here is one I just tested in Fx69 (normal button mode only, not compact or touch):

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button:not([disabled="true"])::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button[disabled="true"]::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"],
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button {
  opacity: 1.0 !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button:not([disabled="true"])::before,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button[disabled="true"]::before {
  display: block !important;
  content: "" !important;
  width: 32px !important;
  height: 32px !important;
  -moz-margin-start: -31px !important;
  -moz-margin-end: -9px !important;
  border-radius: 10000px !important;
  position: relative !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button + #forward-button .toolbarbutton-icon {
  width: 38px !important;
  height: 30px !important;
  padding-top: 6px !important;
  padding-bottom: 6px !important;
  -moz-padding-start: 12px !important;
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button[disabled="true"] .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button[disabled="true"] .toolbarbutton-icon {
  background: lightgrey !important; 
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button:not([disabled="true"]) .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button:not([disabled="true"]) .toolbarbutton-icon {
  background: red !important; 
}

#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #forward-button:not([disabled="true"]):hover .toolbarbutton-icon,
#main-window:not([uidensity=compact]):not([uidensity=touch]) #nav-bar #back-button:not([disabled="true"]):hover .toolbarbutton-icon {
  background: blue !important; 
}

Your second request can be achieve by enabled this option:
https://github.com/Aris-t2/CustomCSSforFx/blob/master/classic/userChrome.css#L714

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Jun 6, 2019

Continue here: #211

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests