Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General discussions, feedback, questions belong here (v3) #88

Closed
Aris-t2 opened this issue Dec 10, 2017 · 271 comments
Closed

General discussions, feedback, questions belong here (v3) #88

Aris-t2 opened this issue Dec 10, 2017 · 271 comments

Comments

@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 10, 2017

Continued from here #3 and here #41

Instead of opening new "issues" for general talk we can use this area for discussions, feedback and questions. Open new "issues" for real bugs and problems.

Trying to make CSS code ready for Firefox Photon (57+)?
Remove all @namespace references. They are the reason, if your code refuses to work.

Application/hamburger button in tabs toolbar?
Look here: #46

Things this project will not target/recreate

  • curved tabs
  • old complete themes
  • ...

Things not possible with CSS

  • more toolbars like add-on/status bar (CSS can not create new toolbars)
    • displaying full sized status popup below window content is possible
    • moving bookmarks toolbar to windows bottom is possible
  • new buttons (CSS can not create new buttons)
  • additional menuitems (CSS can not create new items)
  • custom/new/different functions for buttons/menuitems/menus
  • activity indicator
  • preferences window
  • additional location bar
  • favicon in location bar
  • moving menubar items to a different toolbar
  • restart button
  • ... many more
@Pizzapops
Copy link

Your mod for the overflow add-ons was great but it requires being selective with add-ons. Some add-ons need more width to fully function. Poisencity post a wider horizontal alternative on Reddit/FirefoxCSS that includes the search bar.
overflow_menu_horizontal
I made a few small px tweaks. When customizing, the overflow drop tray is ugly and icons must be dropped at the top of the tray. Search bar should be first, at top.
overflow_menu_horizontal.zip

@radiotech1
Copy link

I tried modifying bookmarks_toolbar_multiple_lines.css. by replacing both "999px" values with "78px" to get 3 lines of bookmarks on the toolbar. I continued to have only one row. Then I downloaded and installed version 1.5.0.1 and I still only have one row. Before I upgraded to Firefox 57 I had 3 rows. When I installed 57 it gave me one row and the other bookmarks are on the bookmark overflow line. What am I doing wrong?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Dec 12, 2017

@Pizzapops
I have added an own version of this as a new option. It is just a simple line and not a grid with fixed values, because this would be too complicated to adjust for every OS / OS theme. Anyway this "feature" was not meant to work with all buttons especially those, that offer sub menus.

@radiotech1
Backup and remove your current code from chrome folder.
Download and extract v1.5.1 https://github.com/Aris-t2/CustomCSSforFx/releases and only edit one line in userChrome.css to enable multiline bookmarks. Does it work now?

If you edit 1.5.1s bookmarks_toolbar_multiple_lines.css file and change

:root {
  --bookmark_items_height: 26px;
  --bookmark_items_lines: 3;
}

to

:root {
  --bookmark_items_height: 999px;
  --bookmark_items_lines: 1;
}

it will behave like in previous builds (if you need to test this).

Make sure you are not trying to combine "multiple bookmarks lines" and "simulated add-on bar" option.

@radiotech1
Copy link

I edited userChome.css for multilines and I now have about 12 rows of Bookmarks and I cant change them. When I modified bookmarks_toolbar_multiple_lines.css with the above code, I still have the 12 rows, but the actual web page content has no room to display. I see the top of them at the bottom of the window and the window is mostly all white.

@radiotech1
Copy link

Ok I went back to the original bookmarks_toolbar_multiple_lines.css and then edited the bookmarks by creating a new folder. It let me move the bookmarks from rows 4-12 in this new folder and I ended up with 3 rows. So I tried creating more book marks and instead of having the overflow chevron on the right it started making a new row of bookmarks.

@Pizzapops
Copy link

Consider a persona based sidebar option. There is no perfect way to do it without themes containing a dedicated graphic. I use solid color themes with my persona_sidebar.css is OK. It is a modified dark sidebar (found elsewhere). Using the footer graphic for the background works most of the time.

background-image: var(--lwt-footer-image) !important; background-size: cover; background-repeat: no-repeat !important;

I still have to pull in the theme font colors. I may post it after some more polish.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Dec 12, 2017

@radiotech1
Sorry, I don't know how to help you. The code works fine here on every system I tested. Post a screenshot.

@Pizzapops
Personas top/bottom background images are way to small for the sidebars, aren't they?

@Fixer-007
Copy link

Fixer-007 commented Dec 12, 2017

After installing Firefox Quantum (portable) did some experiments with CustomCSS and I've pretty much replicated my old-school firefox view (I'm using win7 classic theme). It is indeed much faster, and there are already major addons available that I need, however, I'm still waiting for stuff like Flashgot, Tab Mix Plus, Scrapbook, Add bookmark here 2, Add to Search etc. It turned out better than I expected, I decided to stay on 52ESR for now, but I'm pretty positive about eventual move to Quantum. Thank you for your great work.

@Pizzapops
Copy link

@Aris-t2
Yes, the top and bottom backgrounds are the wrong size for the sidebar. Solids can be manipulated to work without looking ugly. There are lot of themes that should be purged from the Firefox system.

sidebar_appearance_solids.zip

pizzapops_2017-12-12
My modified working FxQ59

@Speravir
Copy link

Speravir commented Dec 13, 2017

@Aris-t2

  1. Apparently I do not count as contributor, hence short answer here:
    In issue #41, comment-350507118

All toolbar jump like this without "appbutton in titlebar" or this projects files in general too, don't they?
Once another bar is present everything has to move

Now that you tell it …

  1. How about adding support for tabs just loading (busy tabs) in custom_text_settings.css, maybe commented, but present? My actual code is derived from your’s for other tab states:
.tabbrowser-tab[busy="true"] .tab-label {
	color: #9933CC !important;
	font-style: italic !important;
	font-weight: initial !important;
	text-shadow: 0px 1px 0px #FFCCFF, 0px 1px 4px #FFCCFF !important;
}

Set after the rule for active tabs it works also for them, and just for these I added the font-weight: initial rule, because these are set in bold weight.

  1. My original goal was to add an animation in the tabline for busy tabs, but I am not able to get it visible for unselected tabs (when loading in background). Do you have an idea? I tried to overwrite the browser rule (for testing without busy):
.tab-line:not([selected="true"]) {
    opacity: 1 !important;
    transform: none !important;
}

This is also the style for hovered tabs where it works.

@aflove65
Copy link

is there any way to integrate curved tabs like this https://github.com/wilfredwee/photon-australis into this and it be below the content?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Dec 13, 2017

@Pizzapops
Your configuration looks great.
There is no way to distinguish between "light" and "dark" lw-themes for "tree entries / bookmarks" or at least I have not found one. Switching between different lw-themes has no effect on sidebars text color. I believe bookmarks/history content does not or can not check lw-theme states, so we only can change the background and top button label based automatically based on lw-theme. Everything else has to be done manually for light and dark lw-themes.

Edit:
I ran some tests and the only "solution" I can currently come up with is adding two different files for sidebar lw-themes, one for dark and one for bright themes.

@Speravir

  1. What exactly are you referring to?
  2. I can add "busy" rules to that file.
  3. I went through the code like a berserker and created this monster example. I hope it helps you find a perfect solution (most code is probably not needed):
.tabbrowser-tab:not([busy="true"]):not(:hover) > .tab-stack > .tab-background > .tab-line:not([selected=true]),
.tabbrowser-tab:not([busy="true"]):hover > .tab-stack > .tab-background > .tab-line:not([selected=true]),
.tabbrowser-tab:not([busy="true"]) > .tab-stack > .tab-background > .tab-line[selected=true],
.tabbrowser-tab:not([busy="true"]) > .tab-stack > .tab-background > .tab-line:not([selected=true]),
.tabbrowser-tab:not([busy="true"]) > .tab-stack > .tab-background > .tab-line {
  height: 2px !important;
  opacity: 1 !important;
  transform: unset !important;
  transition: unset !important;
}

.tabbrowser-tab[busy="true"]:not(:hover) > .tab-stack > .tab-background > .tab-line:not([selected=true]),
.tabbrowser-tab[busy="true"]:hover > .tab-stack > .tab-background > .tab-line:not([selected=true]),
.tabbrowser-tab[busy="true"] > .tab-stack > .tab-background > .tab-line[selected=true],
.tabbrowser-tab[busy="true"] > .tab-stack > .tab-background > .tab-line:not([selected=true]),
.tabbrowser-tab[busy="true"] > .tab-stack > .tab-background > .tab-line {
  height: 2px !important;
  opacity: 1 !important;
  transform: scaleX(0) !important;
  transition: transform 2500ms var(--animation-easing-function), opacity 2500ms var(--animation-easing-function) !important;
}
.tabbrowser-tab > .tab-stack > .tab-background > .tab-line[selected=true] {
  background-color: green !important;
}
.tabbrowser-tab:not(:hover) > .tab-stack > .tab-background > .tab-line:not([selected=true]),
.tabbrowser-tab:hover > .tab-stack > .tab-background > .tab-line:not([selected=true]) {
  background-color: red !important;
}

@aflove65
Sorry, curved tabs won't be part of this project, but you can copy&paste their code in userChrome.css or my_userChrome.css of this project. Unset this projects squared tabs first.

@ghost
Copy link

ghost commented Dec 13, 2017

Sorry, curved tabs won't be part of this project, but you can copy&paste their code in userChrome.css or my_userChrome.css of this project. Unset this projects squared tabs first.

@aflove65: ⚠️

Dark compact theme example:

Active hover
active hover

Maybe use, because better contrast compared to "classic squared tabs".

@Speravir
Copy link

Speravir commented Dec 13, 2017

What exactly are you referring to?

I thought I cited what I referred to, but it’s not that important: It was about the small content jump when activating the menu.

I went through the code like a berserker and created this monster example. I hope it helps you find a perfect solution (most code is probably not needed)

Whoa, this is awesome, you are awesome! May I have been successful myself if I had thought of unset? :-) Now I just have to do some fine tuning (I am really only interested in adding something for busy tabs). You could nonetheless after your investigation add this as style file.

Update:
For busy tabs the following is enough (the height could be omitted because I didn’t change it) – with animation instead of transition.

.tabbrowser-tab:not([busy="true"]) > .tab-stack > .tab-background > .tab-line:not([selected="true"]) {
	opacity: 1 !important;
	transform: unset !important;
	transition: unset !important;
}

@keyframes busytabs {
	from { transform: scaleX(1); }
	to   { transform: scaleX(100); }
}
.tabbrowser-tab[busy="true"]:not(:hover) > .tab-stack > .tab-background > .tab-line:not([selected="true"]),
.tabbrowser-tab[busy="true"]:hover > .tab-stack > .tab-background > .tab-line:not([selected="true"]),
.tabbrowser-tab[busy="true"] > .tab-stack > .tab-background > .tab-line[selected="true"],
.tabbrowser-tab[busy="true"] > .tab-stack > .tab-background > .tab-line:not([selected="true"]),
.tabbrowser-tab[busy="true"] > .tab-stack > .tab-background > .tab-line {
	background-color: #0033FF !important;
	background-image: linear-gradient(to right, transparent 49%, #CCFFFF 50%, transparent 51%) !important;
	animation: busytabs 1s infinite linear alternate !important;
}

The scale factor scaleX(100) has to be adjusted to the width of the linear gradient (the wider the less scale factor). The colours are a matter of taste and depending on the environment, of course. Originally I wanted a moving linear gradient, but this is not possible, because they are not considered an animatable property.
(End of update.)

Regarding fine tuning: This would be one-time hard work for you, but how about adding a style file with lots of variables that will be imported first. These variables then are all over the styles used.

With hard work I mean beside the pure typing thinking of good variable names, commenting these and replacing values where needed.

Another thing that probably would need adjustment: For better delimitation *) I have added some border on top and on bottom of main content:

#content {
	border-top: 2px groove var(--tab-line-color) !important;
	border-bottom: 2px ridge var(--tab-line-color) !important;
}

This looks good here with the light theme I use, but presumably not with the dark theme and other light themes. Also for the default without a statusbar the bottom border probably not should be added.

*) Especially when accidentally the web content has similar colours like the top bars it can be hard to differentiate (I had this case and got the idea then).

And almost forgotten:
You could add an optional top border roundness for default tabs, of course only useful, if the border style is activated, but then it looks good, I think. I copied the code from your squared tabs styles, but made the radius slightly bigger, because this looks better in my eyes for default tabs because of the tab line:

/* tab top border roundness */
#TabsToolbar .tabs-newtab-button,
#TabsToolbar .tabbrowser-tab,
#TabsToolbar .tabbrowser-tab .tab-stack,
#TabsToolbar .tabbrowser-tab .tab-background,
#TabsToolbar .tabbrowser-tab .tab-content {
	border-top-left-radius: 5px !important;
	border-top-right-radius: 5px !important;
}

@WagnerGMD
Copy link

WagnerGMD commented Dec 14, 2017

@import url(./css/aboutaddons/addonlists_show_addon_version_number.css);
## Just one line in my own file userContent.css
## I had just discover the other file userChrome.css and for now it seem's to work fine.

Do you have one trouble on the page about:addons ? Because I can't load it (entirely with Firefox_v58 and that's the reason ?)... In fact, I don't see my list of addons (totally white or empty).
Do you have an idea to correct it ?

PS : Does it exist (one anchor HTML) ? At least, it seem's to be true about:addons#Extensions (for Cyberfox and not Firefox. Unless it's another bug ?).

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Dec 14, 2017

@Speravir
Wasn't that 'line jump' fixed on on of the last releases? The only 'jump' I saw was with 'tabs below titlebar' option and I fixed it (at least for me).

Good you figured out the optimal 'tab busy' configuration for you.

I will add global configuration files for tab and toolbar color settings and more, so we can get rig of all the extra files *_aero.css, *_classic_grey.css etc. Only one file per color has to be imported and it affects all areas like tabs, general toolbars, tabs not on top mode, tabs below content mode etc.

The additional 2px above and below #content may be good for some rare cases, but in general they create an unnecessary gap.

Tab top border roundness for 'default tabs' sound like a good thing to add.

@WagnerGMD
Did you also copy the correct xml file? The mentioned css files binds the code in /smladdonversion_fx57.xml/ and if it is missing, you break the add-ons manager. Make sure you have extracted all files from zip archive to /chrome/ folder correctly.

@LionWrathz
Copy link

LionWrathz commented Dec 14, 2017 via email

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Dec 14, 2017

@LionWrathz
How is it supposed to look? It was white even before Firefox 57 release.

Add this to your userContent.css to change its color:

@-moz-document url-prefix(about:blank) {
	* {
		background: red !important;
	}
}

@LionWrathz
Copy link

LionWrathz commented Dec 14, 2017 via email

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Dec 14, 2017

There was no way we could now you were talking about old add-ons. It sounded like something was broken, but this is not the case.

Old add-ons are gone and so is the code based on them.
There is no Stylish for userChrome/DOM anymore, your code won't work.

I did some experiments with something without Stylish, but the code does not always work properly, because we can not determine about:blank/about:newtab/about:home on root/toolbar/tab level. There is no workaround I know of. Look here to see what is possible with experimental code: #41 (comment)

Never heard of iMacro sidebar. I doubt it works in Firefox 57+.

@WagnerGMD
Copy link

@Aris-t2 Inside the folder xml, I got only 2 files : addonversion_fx57.xml and urlbarBindings_fx57.xml. Wrong name ? Unless I didn't see the error (and the folder was empty) ? It could be true. Because on the moment, (I was thinking) the extraction run fine (yesterday it was custom_css_for_fx_v1.5.1.zip).

As today I believe the trouble might be gone. Let's hope but I was forced to recreate a new profile.

@Speravir
Copy link

Speravir commented Dec 14, 2017

@WagnerGMD

Inside the folder xml, I got only 2 files

Mee too, why should this be wrong? Note, that starting from Fx 58 XBL-bindings are deprecated, cf. #43 and the according notice in userChrome.css.

@Aris-t2

Changes since 1.5.1
[…] moved many code preferences to 'general configuration' files

(etc.) Wow! Did I told you that you are awesome?

If I think there’s an overlooked property that could be set as variable should I create an own issue?
(Edit:
/* @import url(./config/color_variables_classic-grey.css); /**/ /* <- 'classic grey' colors */
comes now twice. )

Good you figured out the optimal 'tab busy' configuration for you.

Yes, I just added the code for information, I apparently should better have set it to the end in my latest posting above. Generally: Some settings are hard to integrate, but too interesting. You could add them on a separate page. From other Github pages I know that it is possible to add a wiki area.

Wasn't that 'line jump' fixed on on of the last releases? The only 'jump' I saw was with 'tabs below titlebar' option and I fixed it (at least for me).

Aah, now do I understand – no, I still have this small jump and I thought you referred to, that this is also the case without a special setting.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Dec 14, 2017

@WagnerGMD
I'm always testing a clean setup of these projects latest zip release inside chrome folder. As for now both XBL bindings offered here (version number in add-on manager and classic autocomplete popup) are working fine in Firefox 57, 58 beta and 59 Nightly on all tested systems (Win7/8/10, macOS 10.1x, Ubuntu and Linux Mint). I don't know, if your configuration is somehow different, but I suggest to create a new browser profile and extract this projects files in chrome folder to see what happens.

@Speravir
There are still a couple of variables, that will be added on next versions, no need to open "new issues" for that. Post a note here, if something is still missing after the next few updates.

In the "default configuration" without changing anything tabs jump into titlebar, if menubar is not present, and jump below it, if it is. Maybe there is a special case with some OS theme / DPI value. Open a new issue and describe the OS configuration the jump occurs with. Add screenshots of "before the jump occurs" and "after it occurs".

@aflove65
Copy link

Do you know the code that will enable spacing between pinned tabs?

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Dec 15, 2017

Should be something like this (untested):

.tabbrowser-tab[pinned]  + .tabbrowser-tab[pinned] {
  -moz-margin-start: 4px !important;
}

@aflove65
Copy link

Thank you that worked!

@Speravir
Copy link

Speravir commented Dec 15, 2017

The styles sidebar_appearance_lwtheme_(bright|dark).css apply the recent light theme to the whole sidebar. I’d like better a style which applies the theme only to the sidebar head (just a copy of the original style):

#sidebar-header {
	background-color: var(--lwt-accent-color) !important;
	background-image: var(--lwt-header-image) !important;
	background-position: bottom left !important;
	background-repeat: no-repeat !important;
}

This also works with the dark sidebar, but the light grey text in the head is barely visible then. I think in the styles mentioned above you have chosen a different variable for background color.

Speaking of the sidebar head: Could you add a style for coloring the symbols there and in the select menu like you did it already for the appbutton (appbutton_popup_icons_colorized.css)?

Open a new issue and describe the OS configuration the jump occurs with.

Hmm, should I really? I noticed the only thing that slightly changes its height is the bookmarks toolbar. I admit, its a complex situation, because you cannot know which of the styles someone has activated.

OK, here you go: See now issue #92.

@stonecrusher
Copy link
Contributor

Did my previous post disappear?

Yes, never seen it.

My fix for FF60+ was just a quick dirty one. Made it as soon as I've seen it.

Just fiddled around a bit. I'm not sure if it is possible providing one code for all FF versions. Atm I'm not smart enough to make it work the way I want it:

Your version has the problem not replacing the button titles, which is the whole point of this.
"Download" is misleading as nothing is downloaded from the net. That button actually just saves.
The other way round, the save button should be titled "upload to cloud" or something similar. Adding "/Cloud" and leaving the other one is not enough for me.

I added the html[dir="ltr"] deliberately (as seen from previous rules in the inspector) to prevent the style applying to sites on the net which may have a button e.g. with class ".highlight-button-download". Applying to wrong sites becomes less probable the more identifiers you add. Speed loss is unrecognizably small.
Actually a @-moz-document rule should also do the job, but moz-extension numbers change every time? #firefox-screenshots-selection-iframe is outside and doesn't work.

Maybe I'll find a solution in the evening.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 28, 2018

@stonecrusher

I wasn't criticizing. Your idea to modify this part of the ui is superb. I just think the labels Save and Download (for the in this case green button) are both just downloading the screenshot, so probably the Cloud button has either to lose the label or completely to go to make this less confusing.

To minimize possible affection of other website one could add more tags to the path, but there won't be a 100% guarantee without any exclusive extension related ids/classes inside the inserted iframe and path to the buttons.
I don't think you can use a @-moz-document on that one, because the code gets inserted into the current page.

The following code

  • hides (red) "Cloud" buttons label
  • uses internal "Download" label for green downloads buttons (automatically localized)
  • works on Firefox 57-60
  • applies code for left-to-right locales only
  • minimizes chance of breaking other website with same button class names (they would also have to use the same ui structure and class names for parent nodes)

-moz-box-ordinal-group or similar does not work on those buttons, so reordering them is not possible for now.

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download  {
  background-color: #1a0 !important;
  width: initial !important;
  -moz-padding-start: 34px !important;
  background-position: 8px center !important;
  border: none !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download img  {
  margin-bottom: -3px !important;
  -moz-margin-start: -28px !important;
  -moz-margin-end: 6px !important;
  width: 18px !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download:hover {
  background-color: #2b0 !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: attr(title) !important;
  font-weight: bold !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save,
html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save {
  background-color: #C00 !important;
  background-position: center !important;
  color: #C00 !important;
  font-size: 0 !important;
  width: 40px !important;
  min-width: 40px !important;
  max-width: 40px !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save:hover,
html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save:hover {
  background-color: #D22 !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save img,
html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save img {
  min-width: 20px !important;
  -moz-margin-start: 7px !important;
}

@stonecrusher
Copy link
Contributor

stonecrusher commented Feb 28, 2018

@Aris-t2

I wasn't criticizing.

Oh I didn't understand it like that and I hope, you don't too. I can be quite direct sometimes which may sound rude in written form. But I'm just spending my time here trying to help, improve and give something back for what I got from this project :-)
I consider it constructive to receive direct feedback.

are both just downloading the screenshot

That's where I disagree. You can't download something from your own PC. Actually it already is on your PC and you just point to where it should be saved.
Usually when you press a save button, it saves at the place where the file was created and in this case that's not the cloud but your local PC.

"Save to PC" and "Upload to cloud" would be the most accurate titles I can think of.
As this is a bit too long, the short forms would also be ok:
"Save" and "Upload" or
"Save" and "Cloud"

Not ok: "Download" and "Save"
Not ok: "Download" and "Save to cloud"
Edge case: "[nothing]" and "Save/Upload to cloud"

Still, written text is always better than an icon which can be misunderstood, especially as the tooltip is also misleading.

/edit
Found out, that they are already aware of it and maybe our "redesign" will be obsolete from FF60.

Concerning the selectors, I think

html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download  { }

will be sufficient, but better to read (skip the whole cascade of + selectors).

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Feb 28, 2018

Alright, you convinced me. The "internal" names will be used for non-localized browser versions. So far I have this:

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download  {
  background-color: #1a0 !important;
  width: initial !important;
  -moz-padding-start: 34px !important;
  background-position: 8px center !important;
  border: none !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download img  {
  margin-bottom: -3px !important;
  -moz-margin-start: -28px !important;
  -moz-margin-end: 6px !important;
  width: 18px !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download:hover {
  background-color: #2b0 !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: attr(title) !important;
  font-weight: bold !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save,
html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save {
  background-color: #C00 !important;
  color: #C00 !important;
  font-size: 0 !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save:hover,
html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save:hover {
  background-color: #D22 !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: attr(title) !important;
  font-weight: bold !important;
}

html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save::after,
html[dir="ltr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save::after {
  content: "Cloud" !important;
  font-size: medium !important;
  color: white !important;
  font-weight: bold !important;
}

/* Language settings */
/* English US*/
html[dir="ltr"][lang="en-US"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: "Save" !important;
}
html[dir="ltr"][lang="en-US"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save::after,
html[dir="ltr"][lang="en-US"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save::after {
  content: "Upload" !important;
}

/* German */
html[dir="ltr"][lang="de"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: "Speichern" !important;
}
html[dir="ltr"][lang="de"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save::after,
html[dir="ltr"][lang="de"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save::after {
  content: "Hochladen" !important;
}

/* French */
html[dir="ltr"][lang="fr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: "Sauvegarder" !important;
}
html[dir="ltr"][lang="fr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save::after,
html[dir="ltr"][lang="fr"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save::after {
  content: "Télécharger" !important;
}

/* Spanish */
html[dir="ltr"][lang="es-ES"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: "Salvar" !important;
}
html[dir="ltr"][lang="es-ES"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save::after,
html[dir="ltr"][lang="es-ES"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save::after {
  content: "Subir" !important;
}

/* Portuguese */
html[dir="ltr"][lang="pt-PT"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: "Salve" !important;
}
html[dir="ltr"][lang="pt-PT"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save::after,
html[dir="ltr"][lang="pt-PT"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save::after {
  content: "Envio" !important;
}

/* Italian */
html[dir="ltr"][lang="it"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: "Salvare" !important;
}
html[dir="ltr"][lang="it"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save::after,
html[dir="ltr"][lang="it"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save::after {
  content: "Caricare" !important;
}

/* Russian */
html[dir="ltr"][lang="ru"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download::after {
  content: "Сохранить" !important;
}
html[dir="ltr"][lang="ru"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.preview-button-save::after,
html[dir="ltr"][lang="ru"] body div.highlight div.highlight-buttons button.highlight-button-cancel + button.highlight-button-copy + button.highlight-button-download + button.highlight-button-save::after {
  content: "Загрузить" !important;
}

@stonecrusher
Copy link
Contributor

Looks great and seems to work in FF58 as well as FF60!
This would be the version with shorter selectors:

click me
html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download  {
  background-color: #1a0 !important;
  width: initial !important;
  -moz-padding-start: 34px !important;
  background-position: 8px center !important;
  border: none !important;
}

html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download img  {
  margin-bottom: -3px !important;
  -moz-margin-start: -28px !important;
  -moz-margin-end: 6px !important;
  width: 18px !important;
}

html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download:hover {
  background-color: #2b0 !important;
}

html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: attr(title) !important;
  font-weight: bold !important;
}

html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save,
html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save {
  background-color: #C00 !important;
  color: #C00 !important;
  font-size: 0 !important;
}

html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save:hover,
html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save:hover {
  background-color: #D22 !important;
}

html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: attr(title) !important;
  font-weight: bold !important;
}

html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save::after,
html[dir="ltr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save::after {
  content: "Cloud" !important;
  font-size: medium !important;
  color: white !important;
  font-weight: bold !important;
}

/* Language settings */
/* English US*/
html[dir="ltr"][lang="en-US"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: "Save" !important;
}
html[dir="ltr"][lang="en-US"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save::after,
html[dir="ltr"][lang="en-US"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save::after {
  content: "Upload" !important;
}

/* German */
html[dir="ltr"][lang="de"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: "Speichern" !important;
}
html[dir="ltr"][lang="de"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save::after,
html[dir="ltr"][lang="de"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save::after {
  content: "Hochladen" !important;
}

/* French */
html[dir="ltr"][lang="fr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: "Sauvegarder" !important;
}
html[dir="ltr"][lang="fr"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save::after,
html[dir="ltr"][lang="fr"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save::after {
  content: "Télécharger" !important;
}

/* Spanish */
html[dir="ltr"][lang="es-ES"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: "Salvar" !important;
}
html[dir="ltr"][lang="es-ES"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save::after,
html[dir="ltr"][lang="es-ES"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save::after {
  content: "Subir" !important;
}

/* Portuguese */
html[dir="ltr"][lang="pt-PT"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: "Salve" !important;
}
html[dir="ltr"][lang="pt-PT"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save::after,
html[dir="ltr"][lang="pt-PT"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save::after {
  content: "Envio" !important;
}

/* Italian */
html[dir="ltr"][lang="it"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: "Salvare" !important;
}
html[dir="ltr"][lang="it"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save::after,
html[dir="ltr"][lang="it"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save::after {
  content: "Caricare" !important;
}

/* Russian */
html[dir="ltr"][lang="ru"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-download::after {
  content: "Сохранить" !important;
}
html[dir="ltr"][lang="ru"] > body > div.highlight > div.highlight-buttons:first-child > button.preview-button-save::after,
html[dir="ltr"][lang="ru"] > body > div.highlight > div.highlight-buttons:first-child > button.highlight-button-save::after {
  content: "Загрузить" !important;
}

@krystian3w
Copy link
Contributor

krystian3w commented Mar 2, 2018

Did my previous post disappear? Is Github bugged?

Maybe time to create v4 feedback topic.

Or try add new post when github was attacked - githubengineering.com/ddos-incident-report/.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Mar 2, 2018

@krystian3w

Looks like my lost post could really fall in that time 3 days ago.

Continue here: #109

@Aris-t2 Aris-t2 closed this as completed Mar 2, 2018
@RudigerS
Copy link

RudigerS commented Mar 4, 2018

I can't remove the grey boxes behind the icons. I have tried a lot of different combinations to fix it but nothing seems to work. Any ideas? I am using it on OS X
2018-03-04_13-53-24

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Mar 4, 2018

Witch version of Firefox and OSX are you using?
I don't see this happen on macOS 10.3.x.

Have you tried a clean setup of this project (without modifying any settings)?

@RudigerS
Copy link

RudigerS commented Mar 8, 2018

I tried a clean setup it loads fine. The issue still occurs when I choose @import url(./css/toolbars/toolbar_mode_icons_and_text.css); /**/
I didn't change any other settings in the file
I am using FF 58.0.2 OS X 10.12.6
ff_clean

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Mar 8, 2018

Alright, I can reproduce this issue now. Not sure which version of the project introduced it again (it was fixed a while ago), but it will be fixed on next update. There will be an additional file to import for macOS: toolbar_mode_icons_and_text_and_text_only_macOS_fix.css

Could we continue this discussion in #109 after I uploaded 1.7.6?

@Przbl
Copy link

Przbl commented Mar 17, 2018

Hi, I just updated from v1.5.9 to v1.7.8, adapted my settings to the ones before but can't find a certain item: compared to my previous settings now I have a border around my menu bar (see attached before and after screenshots). Can anyone tell me where i can find the corresponding setting to remove the border?
Before After

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Mar 17, 2018

It most likely was menubar > menubar color?
If you have your previous userChrome.css backed up, you can compare it to your new one with e.g. Notepad++ > Plugin > Compare

@Przbl
Copy link

Przbl commented Mar 17, 2018

Sadly, it was not. I have backups and compared those files. The line in the userChrome.css for menubar_color.css was enabled in both versions; the file menubar_colors.css itself didn't change except for the header text. Must be somewhere else.

@Aris-t2
Copy link
Owner Author

Aris-t2 commented Mar 18, 2018

Looks like a not-updated menubar_colors.css is the reason for this problem. Other toolbar related code changed over time.

Replace its content with this (next updates code will contain this too):

/* Firefox Quantum userChrome.css tweaks ************************************************/
/* Github: https://github.com/aris-t2/customcssforfx ************************************/
/****************************************************************************************/


:root {
  --colored_menubar_background_image: linear-gradient(#f9f9fa,#f9f9fa);
  --colored_menubar_text_color: inherit;
}

#toolbar-menubar:not(:-moz-lwtheme) {
  background-image: var(--colored_menubar_background_image) !important;
  /*border: 1px solid var(--tabs-border-color) !important;
  border-bottom: 0px !important;*/
  border: 0px !important;
  margin-bottom: -1px !important;
}

@media (-moz-os-version:windows-win8),(-moz-os-version:windows-win10) {
  #main-window[tabsintitlebar] #titlebar-min .toolbarbutton-icon,
  #main-window[tabsintitlebar] #titlebar-max .toolbarbutton-icon,
  #main-window[tabsintitlebar] #titlebar-close:not(:hover) .toolbarbutton-icon {
	fill: var(--colored_menubar_text_color) !important;
	color: var(--colored_menubar_text_color) !important;
	stroke: var(--colored_menubar_text_color) !important;
  }
}

#nav-bar {
  border-top: 0px !important;
  box-shadow: unset !important;
}

#main-window:not(:-moz-lwtheme) #main-menubar > menu > :-moz-any(label,description) {
  color: var(--colored_menubar_text_color) !important;
}

Am I assuming right you are using tabs toolbar on bottom or disabled it completely?

@Aris-t2 Aris-t2 reopened this Mar 18, 2018
@Aris-t2 Aris-t2 closed this as completed Mar 18, 2018
@Przbl
Copy link

Przbl commented Mar 18, 2018

Great news, thanks! I updated the menubar_colors.css with your code and everything looks perfect now!

Am I assuming right you are using tabs toolbar on bottom or disabled it completely?

No, but I am using code to hide the tab bar when only one tab is open. When taking the screenshot I had no other tabs opened so there's no tab bar but only this yellow line (which is a remnant of other code that reproduces the colorful-tab's tab-stack. This is the same color the respective active tab has. I just didn't find a way to hide it completely).

P.S.: and sorry for reviving this v3, I only just found out that there's a new support thread v4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests