Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceInfoService #31

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jmlich
Copy link

@jmlich jmlich commented Feb 7, 2024

This is try to implement Device Info Service
https://www.bluetooth.com/specifications/specs/device-information-service-1-1/

  • The minimalistic implementation is part of bluez and it is necessary to turn it off:
echo DeviceID = false >> /etc/bluetooth/main.conf

The AsteroidOS/meta-asteroid#184 should be merged in the same time

screenshot20240207_192023112

@jmlich
Copy link
Author

jmlich commented Feb 8, 2024

I am still not sure if it is written correctly. I have seen some situation when the data wasn't refreshed/loaded even if they should.

@jmlich
Copy link
Author

jmlich commented Feb 8, 2024

The PnP ID was dropped, as it seems other devices (e.g. PineTime) also doesn't implement that always.

src/deviceinfoservice.cpp Outdated Show resolved Hide resolved
src/deviceinfoservice.cpp Outdated Show resolved Hide resolved
src/deviceinfoservice.cpp Outdated Show resolved Hide resolved
@jmlich
Copy link
Author

jmlich commented Feb 13, 2024

I have updated the comments.

@jmlich jmlich marked this pull request as draft February 17, 2024 14:35
@FlorentRevest
Copy link
Member

FWIW (I also had to refresh my mind to remember the state of those PRs :) ) this PR and AsteroidOS/asteroid-settings#97 both looked good to me.

The only reason why these are not merged is because AsteroidOS/meta-asteroid#185 should have been implemented in a different way so it's not Android-specific. With that implemented, I'd gladly merge those PRs.

@jmlich
Copy link
Author

jmlich commented Apr 17, 2024

It is still in my backlog. There is just a lot of other things to do (-;

@FlorentRevest
Copy link
Member

All good! I just wanted to check I didn't miss anything :) no rush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants