Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emulator: Move qemux86-specific changes into separate machine meta layer #239

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

casept
Copy link

@casept casept commented Feb 13, 2024

Previously, qemux86-related changes were strewn all over meta-asteroid, which went against the way all other machines are handled.

This change creates a new "smartwatch" machine, called emulator. It inherits most machine configuration from openembedded's qemux86 machine.

The patches, configs etc. are basically the same as they were in meta-asteroid, the interesting change is the creation of a dedicated machine.conf.

Also see AsteroidOS/meta-asteroid#188 for the removal from meta-asteroid and AsteroidOS/asteroid#281 for renaming in the build script.

@casept
Copy link
Author

casept commented Feb 13, 2024

Oops, looks like I managed to break mouse support. Converting back to draft until that's fixed

@casept casept marked this pull request as draft February 13, 2024 18:54
@FlorentRevest
Copy link
Member

I see this is still marked as draft, presumably because you haven't gotten a chance to fix mouse support, is that right ?

This is the reason why I have not commented on AsteroidOS/asteroid#281 and AsteroidOS/meta-asteroid#188 and this one yet.

FWIW, the changes look good to me overall. Are you sure that mouse support even worked before your refactoring ? If not, that's a strict improvement and we can move forward with it anyway. If something did break though, it would be good to figure it out before merging :)

Previously, qemux86-related changes were strewn all over meta-asteroid,
which went against the way all other machines are handled.

This change creates a new "smartwatch" machine, called emulator. It inherits
most machine configuration from openembedded's qemux86 machine.

The patches, configs etc. are basically the same as they were in meta-asteroid,
the interesting change is the creation of a dedicated machine.conf.
@beroset
Copy link
Member

beroset commented Apr 17, 2024

I think the idea of this is good. One thing that I wonder about is whether, by renaming from qemux86 to emulator if we might lose some of the Yocto functionality that uses qemu. See https://docs.yoctoproject.org/dev-manual/qemu.html

@casept
Copy link
Author

casept commented Apr 17, 2024

Yes, I'm sure that the mouse support does work on the current master and is broken by my PR.

I think I've managed to narrow it down to a strange configuration installation issue - for whatever reason, when I try to override the search path for asteroid-launcher-configs in a .bbappend in meta-emulator to install the proper configs, bitbake silently ignores the changes. If I make the prepend unconditional it works, but obviously breaks other machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants