implement the unix domain socket #1688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slandelle
requested changes
Jan 7, 2020
client/src/main/java/org/asynchttpclient/RequestBuilderBase.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/EpollDomainTransportFactory.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/KQueueDomainTransportFactory.java
Outdated
Show resolved
Hide resolved
| abort(null, future, getCause(cause)); | ||
| } | ||
| }); | ||
| }else { |
There was a problem hiding this comment.
My idea does not meet the formatting rules, please help format
|
Thanks for your code review, I will take the time to solve the problem of breaking these existing APIs. |
|
I have reduced the breaking of the original API |
|
Can I ask which version can incorporate this function? |
slandelle
force-pushed
the
master
branch
5 times, most recently
from
6ea11f4
to
f8fab66
Compare
|
When will this feature be supported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage can see example.CompletableFutures