New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support brotli #1938

Merged

hyperxpro merged 4 commits into AsyncHttpClient:main from sullis:sean/brotli4j

Mar 1, 2024

Contributor

sullis commented Feb 28, 2024 •

edited

Related


          support brotli

b1b9b77

Contributor Author

sullis commented Feb 28, 2024

hyperxpro reviewed

View reviewed changes

client/pom.xml Outdated Show resolved Hide resolved

sullis added 2 commits

February 28, 2024 10:44


          brotli4j optional=true

7dc2614


          cleanup whitespace

5b9afe4

sullis marked this pull request as ready for review

February 29, 2024 07:23

Contributor Author

sullis commented Feb 29, 2024

ready for review

Member

hyperxpro commented Mar 1, 2024 •

edited

Do not add dependency in dependencyManagement. Move them under dependencies and make them optional here.


          fix brotli4j dependencies

a7fa29d

hyperxpro approved these changes

View reviewed changes

Contributor Author

sullis commented Mar 1, 2024

ready to merge

hyperxpro merged commit 631c3b0 into AsyncHttpClient:main

3 checks passed

Member

hyperxpro commented Mar 1, 2024

Thanks a lot! :)

sullis deleted the sean/brotli4j branch

March 1, 2024 16:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment